Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34137

Offer mod_label as an option when drag/dropping media mime-types

    Details

    • Testing Instructions:
      Hide
      1. Visit Settings > Site admin > plugins > activity modules > label
      2. Tick the 'media drag and drop' setting
      3. Visit a course page
      4. Drag one or more images onto the page (note: must be 'web_image' types - jpeg, png, gif or svg)
      5. Select 'Create label' from the dialog
        • Confirm that a label is created for each image
        • Confirm that all of the editing icons work as expected (without a page refresh)
      6. Refresh the page (or load in a separate tab)
        • confirm that the layout of labels is unchanged after the refresh
      7. Revisit Settings > Site admin > plugins > activity modules > label
      8. Go back to the course and attempt to upload another image
        • Confirm that the image uploads immediately as a file resource without the 'label' option being presented
      9. Check that each of the images uploaded is being constrained to the maximum dimensions specified on the global settings page
      10. Check that images smaller than the maximum dimensions are not resized
      11. Check that disabling both width & height restrictions prevents uploaded images from being resized
      12. Check that resized images are linked to the full-sized original

      Note: this will only work on browsers supporting drag and drop (Safari, Chrome, Firefox, IE10). It should be tested on each of those browsers.

      Note: SVG images have their width set to the maximum and their height left to resize automatically in the browser. This is due to there not being any current support for determining the aspect ratio of an SVG image, so I cannot adjust the height without distorting the image.

      Show
      Visit Settings > Site admin > plugins > activity modules > label Tick the 'media drag and drop' setting Visit a course page Drag one or more images onto the page (note: must be 'web_image' types - jpeg, png, gif or svg) Select 'Create label' from the dialog Confirm that a label is created for each image Confirm that all of the editing icons work as expected (without a page refresh) Refresh the page (or load in a separate tab) confirm that the layout of labels is unchanged after the refresh Revisit Settings > Site admin > plugins > activity modules > label Go back to the course and attempt to upload another image Confirm that the image uploads immediately as a file resource without the 'label' option being presented Check that each of the images uploaded is being constrained to the maximum dimensions specified on the global settings page Check that images smaller than the maximum dimensions are not resized Check that disabling both width & height restrictions prevents uploaded images from being resized Check that resized images are linked to the full-sized original Note: this will only work on browsers supporting drag and drop (Safari, Chrome, Firefox, IE10). It should be tested on each of those browsers. Note: SVG images have their width set to the maximum and their height left to resize automatically in the browser. This is due to there not being any current support for determining the aspect ratio of an SVG image, so I cannot adjust the height without distorting the image.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
      MDL-34137_label_dndupload

      Description

      When you drag and drop a image or media file into a Moodle page - it seems as though Moodle treats it as a resource to share and it becomes a link.

      Can it also be embedded in the page so that the image can be seen or the video embedded so it can stream? Easily customizing the appearance of a page (without the need to create a label first) would de great.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  35 Vote for this issue
                  Watchers:
                  31 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/May/13