Moodle
  1. Moodle
  2. MDL-34139

filemanager dialogues automatically process the first button when 'Enter' is pressed

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3.2
    • Component/s: Filepicker
    • Labels:
    • Testing Instructions:
      Hide

      don't forget to purge cache before testing!

      1. Open Private files, create folder and add files to it
      2. Click on file, change it's name and hit Enter
      3. Make sure file name is changed and file did not start downloading
      4. Right-click on folder, change name and hit Enter
      5. Make sure folder is renamed

      Show
      don't forget to purge cache before testing! 1. Open Private files, create folder and add files to it 2. Click on file, change it's name and hit Enter 3. Make sure file name is changed and file did not start downloading 4. Right-click on folder, change name and hit Enter 5. Make sure folder is renamed
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE

      Description

      as a result of MDL-33130 (when <a>s were replaced with <button>s), the filemanager/filepicker dialogues react to the key 'Enter'

      This is all right in the most cases. But in cases when user tries to rename file or folder in filemanager, the first button is autopressed, which is 'Download' or 'Delete'

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Sam Hemelryk added a comment -

            Thanks Marina, this has been integrated now.

            Show
            Sam Hemelryk added a comment - Thanks Marina, this has been integrated now.
            Hide
            Frédéric Massart added a comment -

            Test passed on master! Yay!

            Show
            Frédéric Massart added a comment - Test passed on master! Yay!
            Hide
            Dan Poltawski added a comment -

            Congratulations!

            You've made it into the weekly release!

            Thanks for your contribution - here are some random drummers to keep you inspired for the next week!
            http://www.youtube.com/watch?v=_QhpHUmVCmY

            Show
            Dan Poltawski added a comment - Congratulations! You've made it into the weekly release! Thanks for your contribution - here are some random drummers to keep you inspired for the next week! http://www.youtube.com/watch?v=_QhpHUmVCmY

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: