Moodle

Popup not closed after a student finishes attempt in a quiz

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.3
  • Fix Version/s: 2.2.5, 2.3.2
  • Component/s: Quiz
  • Labels:
  • Testing Instructions:
    Hide

    1. Create a quiz with the following settings: 'Browser security' set to 'Popup and javascript ...'

    2. 'How questions behave' set to 'Deferred feedback'.

    3. ... and 'Review options', 'Immediately after the attempt', all options in that column disabled.

    4. Then add some questions to the quiz, and attempt it as a student.

    5. When you get to the end of the quiz, the pop-up window should close automatically.

    (Note to testers, it now seems that Chrome and Firefox pop-up blockers are getting more and more aggressive, which means that what Moodle (some crazy control-freak teachers who use Moodle) whan to do is getting harder and harder to keep working. I suggest you test this on a browser like IE, where full-screen pop-ups still work.)

    Show
    1. Create a quiz with the following settings: 'Browser security' set to 'Popup and javascript ...' 2. 'How questions behave' set to 'Deferred feedback'. 3. ... and 'Review options', 'Immediately after the attempt', all options in that column disabled. 4. Then add some questions to the quiz, and attempt it as a student. 5. When you get to the end of the quiz, the pop-up window should close automatically. (Note to testers, it now seems that Chrome and Firefox pop-up blockers are getting more and more aggressive, which means that what Moodle (some crazy control-freak teachers who use Moodle) whan to do is getting harder and harder to keep working. I suggest you test this on a browser like IE, where full-screen pop-ups still work.)
  • Affected Branches:
    MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_22_STABLE, MOODLE_23_STABLE
  • Pull from Repository:
  • Pull Master Branch:
  • Pull Master Diff URL:

Description

1. Create a quiz that allows multiple attempts, and set to Browser security: 'Popup ...', and no review allowed immediately after the attempt.
2. Add a question to the quiz
3. Create a student account and access the quiz.
4. Finish an attempt
5. Ensure a valid message is displayed.
Actual:-
The popup is not closed
Expected:-
6. pop-up window then closes after a few seconds.

I tested this with chromium on ubuntu.

Issue Links

discovered while testing

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-34025 Call to close_attempt_popup passes parameters in wrong order.

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.
has been marked as being related by

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-34257 Quiz attempt popup doesn't respect theme's config.php layout array

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tim Hunt added a comment -

I am getting:

'M.mod_quiz.secure_window' is null or not an object review.php?attempt=516, line 137 character 1

in IE's error console.

Show
Tim Hunt added a comment - I am getting: 'M.mod_quiz.secure_window' is null or not an object review.php?attempt=516, line 137 character 1 in IE's error console.
Hide
Permalink
Tim Hunt added a comment -

OK, I think this fixes it. I added some people interested in secure mode as watchers in the hope they could give a quick peer-review / test before I submit this for integration.

Show
Tim Hunt added a comment - OK, I think this fixes it. I added some people interested in secure mode as watchers in the hope they could give a quick peer-review / test before I submit this for integration.
Hide
Permalink
Tim Hunt added a comment -

I am confident enough that this is right that I am going to submit it for integration.

Show
Tim Hunt added a comment - I am confident enough that this is right that I am going to submit it for integration.
Hide
Permalink
Dan Poltawski added a comment -

Integrated, thanks Tim.

Show
Dan Poltawski added a comment - Integrated, thanks Tim.
Hide
Permalink
Michael de Raadt added a comment -

Test result: Success!

Tested in Master on FF, Chrome, IE, Opera and Safari.

Tested in 2.3 and 2.2 in Chrome.

Show
Michael de Raadt added a comment - Test result: Success! Tested in Master on FF, Chrome, IE, Opera and Safari. Tested in 2.3 and 2.2 in Chrome.
Hide
Permalink
Dan Poltawski added a comment -

*Notice*: Undefined variable: friendlyintegrator in /Users/danp/git/tokenintegrationthanks.php on line 26

Congratulations

{tracker.user.name}

!

You've made into Moodle

{tracker.fixversion-1}

+

I would like to personally thank you for this contribution on behalf of all Moodle users throughout the world.

cheers!

{tracker.friendlyintegrator}
Show
Dan Poltawski added a comment - * Notice *: Undefined variable: friendlyintegrator in /Users/danp/git/tokenintegrationthanks.php on line 26 Congratulations {tracker.user.name} ! You've made into Moodle {tracker.fixversion-1} + I would like to personally thank you for this contribution on behalf of all Moodle users throughout the world. cheers! {tracker.friendlyintegrator}
Hide
Permalink
Aparup Banerjee added a comment - - edited

just noting here this confusion (while doing a revert for MDL-34257):

648c1ad Merge branch 'MDL-34187' of git://github.com/timhunt/moodle
ddda79c MDL-34257 quiz 'secure' window: does not close automatically.

Show
Aparup Banerjee added a comment - - edited just noting here this confusion (while doing a revert for MDL-34257 ): 648c1ad Merge branch ' MDL-34187 ' of git://github.com/timhunt/moodle ddda79c MDL-34257 quiz 'secure' window: does not close automatically.

People

Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: