Moodle
  1. Moodle
  2. MDL-34198

SCORM interactions report - extra get_records call

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.2.5, 2.3.2
    • Component/s: SCORM
    • Labels:

      Description

      The call to:
      $attempts = $DB->get_records_sql($select.$from.$where, $params);
      on line 186 scorm/report/interactions/report.php doesn't appear to be needed?

        Gliffy Diagrams

          Activity

          Hide
          Dan Marsden added a comment -

          adding Ankit here - any chance you could peer review this?

          thanks!

          Show
          Dan Marsden added a comment - adding Ankit here - any chance you could peer review this? thanks!
          Hide
          Ankit Agarwal added a comment -

          Nice spotting. Thanks For fixing that.
          Looks good to me.

          Show
          Ankit Agarwal added a comment - Nice spotting. Thanks For fixing that. Looks good to me.
          Hide
          Ankit Agarwal added a comment -

          Added some testing instructions and submitting for integration.
          Thanks

          Show
          Ankit Agarwal added a comment - Added some testing instructions and submitting for integration. Thanks
          Hide
          Dan Poltawski added a comment -

          Are you happy with master only for this?

          Show
          Dan Poltawski added a comment - Are you happy with master only for this?
          Hide
          Ankit Agarwal added a comment -

          I guess this should be cherry-picked to stables as well.

          Show
          Ankit Agarwal added a comment - I guess this should be cherry-picked to stables as well.
          Hide
          Dan Marsden added a comment -

          would be nice to see this on master and 23Stable if possible but if integrators prefer master only that's fine by me.

          Show
          Dan Marsden added a comment - would be nice to see this on master and 23Stable if possible but if integrators prefer master only that's fine by me.
          Hide
          Dan Poltawski added a comment -

          Thanks guys, integrated to 22, 23 and master.

          Show
          Dan Poltawski added a comment - Thanks guys, integrated to 22, 23 and master.
          Hide
          Adrian Greeve added a comment -

          I loaded up the quiz and completed the quiz with a few students. I had a look at the Interactions report and I couldn't spot any regressions.
          The only problem I found was when trying to sort the report by response, but I tried this in Master and observed that it happens there too.
          Test Passed

          Show
          Adrian Greeve added a comment - I loaded up the quiz and completed the quiz with a few students. I had a look at the Interactions report and I couldn't spot any regressions. The only problem I found was when trying to sort the report by response, but I tried this in Master and observed that it happens there too. Test Passed
          Hide
          Dan Poltawski added a comment -

          Congratulations!

          You've made it into the weekly release!

          Thanks for your contribution - here are some random drummers to keep you inspired for the next week!
          http://www.youtube.com/watch?v=_QhpHUmVCmY

          Show
          Dan Poltawski added a comment - Congratulations! You've made it into the weekly release! Thanks for your contribution - here are some random drummers to keep you inspired for the next week! http://www.youtube.com/watch?v=_QhpHUmVCmY

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: