Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31167 PHP strict META
  3. MDL-34204

Strict standards: Non-static method grade_report_grader::process_action()

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3.4
    • Component/s: Gradebook
    • Labels:
    • Testing Instructions:
      Hide

      1. Go to the gradebook (grader report) in any course.

      2. Click the [-] icon next to any category (in the column headings).

      3. Verify that there are no Strict Syntax warnings.

      Show
      1. Go to the gradebook (grader report) in any course. 2. Click the [-] icon next to any category (in the column headings). 3. Verify that there are no Strict Syntax warnings.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Strict standards: Non-static method grade_report_grader::process_action() should not be called statically in 
      /home/fred/www/repositories/stable_master/moodle/grade/report/grader/index.php on line 110 
      Call Stack: 0.0007 728384 
      1. {main}() /home/fred/www/repositories/stable_master/moodle/grade/report/grader/index.php:0 

      1. Go to the gradebook
      2. Click on the little icon next to the course name (Aggregates only)
      3. Notice appears on next page}

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            poltawski Dan Poltawski added a comment -

            Just saw this one myself

            Show
            poltawski Dan Poltawski added a comment - Just saw this one myself
            Hide
            timhunt Tim Hunt added a comment -

            Note that we cannot just change process_action() to be a static method. That method is defined in the base class as an abstract method, so we cannot change the API in a subclass.

            Show
            timhunt Tim Hunt added a comment - Note that we cannot just change process_action() to be a static method. That method is defined in the base class as an abstract method, so we cannot change the API in a subclass.
            Hide
            poltawski Dan Poltawski added a comment -

            Integrated, thanks.

            This is a bit ugly, but such is the life of STABLE bugfixes, I guess.

            Show
            poltawski Dan Poltawski added a comment - Integrated, thanks. This is a bit ugly, but such is the life of STABLE bugfixes, I guess.
            Hide
            rwijaya Rossiani Wijaya added a comment -

            This works as expected.

            Tested for 2.3 and master

            Test passed.

            Show
            rwijaya Rossiani Wijaya added a comment - This works as expected. Tested for 2.3 and master Test passed.
            Hide
            poltawski Dan Poltawski added a comment -

            Congratulations! Another bug solved.. only another 7330 to go, thanks for contributing to contributing to 0.8% of all bugs being fixed this week!

            ciao
            Dan

            Show
            poltawski Dan Poltawski added a comment - Congratulations! Another bug solved.. only another 7330 to go, thanks for contributing to contributing to 0.8% of all bugs being fixed this week! ciao Dan

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Jan/13