Details

    • Testing Instructions:
      Hide

      With no user setting set for activity chooser:

      1. Go to course and turn editing on - activity chooser should still be available
      2. Change setting to false
      3. Return to course and turn editing on - activity/resource selects should be available

      With user setting set for activity chooser

      1. Changing admin setting should have no effect
      Show
      With no user setting set for activity chooser: Go to course and turn editing on - activity chooser should still be available Change setting to false Return to course and turn editing on - activity/resource selects should be available With user setting set for activity chooser Changing admin setting should have no effect
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-34205-master

      Description

      It would be useful to be able to select whether or not the new 2.3 activity chooser is presented to users by default.

      An example case for this is where an institution would like to upgrade to 2.3 to take advantage of many of the new features, but needs time to update all support materials (e.g. how-to screenshots) to take into account the new user interface.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            maherne Michael Aherne added a comment -

            Added pull request for an implementation of this setting.

            Show
            maherne Michael Aherne added a comment - Added pull request for an implementation of this setting.
            Hide
            tsala Helen Foster added a comment -

            Michael, thanks for your report and patch. Hopefully it can be reviewed soon.

            Show
            tsala Helen Foster added a comment - Michael, thanks for your report and patch. Hopefully it can be reviewed soon.
            Hide
            dobedobedoh Andrew Nicols added a comment -

            Hi Michael,

            Do you want this peer reviewing yet? Can you put it up for Peer Review?

            Cheers,

            Andrew

            Show
            dobedobedoh Andrew Nicols added a comment - Hi Michael, Do you want this peer reviewing yet? Can you put it up for Peer Review? Cheers, Andrew
            Hide
            maherne Michael Aherne added a comment -

            Hi Andrew, I haven't used the "request peer review" button before - how do I determine who to put in as peer reviewer?

            Cheers

            Michael

            Show
            maherne Michael Aherne added a comment - Hi Andrew, I haven't used the "request peer review" button before - how do I determine who to put in as peer reviewer? Cheers Michael
            Hide
            dobedobedoh Andrew Nicols added a comment -

            Hi Michael,

            A peer reviewer will be assigned - typically by the component lead, or by someone interested in the feature.
            In this case, I've already assigned myself as a peer reviewer as I originally wrote the activity chooser.

            There's an overview of the whole development process on the wiki at http://docs.moodle.org/dev/Process including a (very brief) description of how to put your item up for Peer Review - http://docs.moodle.org/dev/Process#Submit_your_code_for_peer_review

            Andrew

            Show
            dobedobedoh Andrew Nicols added a comment - Hi Michael, A peer reviewer will be assigned - typically by the component lead, or by someone interested in the feature. In this case, I've already assigned myself as a peer reviewer as I originally wrote the activity chooser. There's an overview of the whole development process on the wiki at http://docs.moodle.org/dev/Process including a (very brief) description of how to put your item up for Peer Review - http://docs.moodle.org/dev/Process#Submit_your_code_for_peer_review Andrew
            Hide
            maherne Michael Aherne added a comment -

            Thanks Andrew - I get it now!

            Show
            maherne Michael Aherne added a comment - Thanks Andrew - I get it now!
            Hide
            dobedobedoh Andrew Nicols added a comment -

            This looks good to me. Feel free to submit for IR when ready.

            Show
            dobedobedoh Andrew Nicols added a comment - This looks good to me. Feel free to submit for IR when ready.
            Hide
            maherne Michael Aherne added a comment -

            Thanks, Andrew. How do I submit it for integration review? It's not clear from the documentation you sent, and I don't see any options in the buttons I have available. Sorry if I'm missing something obvious!

            Cheers

            Michael

            Show
            maherne Michael Aherne added a comment - Thanks, Andrew. How do I submit it for integration review? It's not clear from the documentation you sent, and I don't see any options in the buttons I have available. Sorry if I'm missing something obvious! Cheers Michael
            Hide
            dobedobedoh Andrew Nicols added a comment -

            Hi Michael,

            I've submitted this for IR now - I have no way of knowing who does and who doesn't have the ability to send for IR. If you'd like the ability to do this yourself in the future, best to ping Michael D (michaeld@moodle.com).

            Andrew

            Show
            dobedobedoh Andrew Nicols added a comment - Hi Michael, I've submitted this for IR now - I have no way of knowing who does and who doesn't have the ability to send for IR. If you'd like the ability to do this yourself in the future, best to ping Michael D (michaeld@moodle.com). Andrew
            Hide
            maherne Michael Aherne added a comment -

            Thanks, Andrew. I've contacted Michael to see if he's willing to give me this permission.

            Show
            maherne Michael Aherne added a comment - Thanks, Andrew. I've contacted Michael to see if he's willing to give me this permission.
            Hide
            poltawski Dan Poltawski added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks guys, this has been integrated now.
            Please note that as this is a new feature it was integrated to master only, as such won't be available until 2.4 sorry.
            If there's a good case to backport then it can be considered as a separate issue.

            Cheers
            Sam

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks guys, this has been integrated now. Please note that as this is a new feature it was integrated to master only, as such won't be available until 2.4 sorry. If there's a good case to backport then it can be considered as a separate issue. Cheers Sam
            Hide
            rwijaya Rossiani Wijaya added a comment -

            This looks great.

            Test passed.

            Show
            rwijaya Rossiani Wijaya added a comment - This looks great. Test passed.
            Hide
            maherne Michael Aherne added a comment -

            Thanks everyone! I've created a new issue, MDL-34534, to look at backporting this to 2.3 as I think it's important to have it available alongside the new activity chooser.

            Cheers

            Michael

            Show
            maherne Michael Aherne added a comment - Thanks everyone! I've created a new issue, MDL-34534 , to look at backporting this to 2.3 as I think it's important to have it available alongside the new activity chooser. Cheers Michael
            Hide
            marycooch Mary Cooch added a comment -

            Just adding docs_required label in prep for 2.4

            Show
            marycooch Mary Cooch added a comment - Just adding docs_required label in prep for 2.4
            Hide
            nebgor Aparup Banerjee added a comment -

            yay, it works!

            This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.

            Thank you all for taking the time to get us here.

            cheers!

            Show
            nebgor Aparup Banerjee added a comment - yay, it works! This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week. Thank you all for taking the time to get us here. cheers!
            Hide
            marycooch Mary Cooch added a comment -

            Removing docs_required label as this was documented when backported to 2.3

            Show
            marycooch Mary Cooch added a comment - Removing docs_required label as this was documented when backported to 2.3

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Dec/12