Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34217

Strings in the assignment settings

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.1
    • Fix Version/s: 2.3.2
    • Component/s: Assignment
    • Labels:
      None
    • Testing Instructions:
      1. View assignment settings page: "Site administration" => "Plugins" => Activity Modules" => "Assignment"
      2. "Feedback Plugin" should be on left of setting and long description should be underneath.
    • Workaround:
      Hide

      moodle/mod/assign/settings.php in line 52 to 54

      $settings->add(new admin_setting_configselect('assign/feedback_plugin_for_gradebook',
                     new lang_string('feedbackplugin', 'mod_assign'),
                     new lang_string('feedbackpluginforgradebook', 'mod_assign'), 'assignfeedback_comments', $menu));
       

      Show
      moodle/mod/assign/settings.php in line 52 to 54 $settings->add(new admin_setting_configselect('assign/feedback_plugin_for_gradebook', new lang_string('feedbackplugin', 'mod_assign'), new lang_string('feedbackpluginforgradebook', 'mod_assign'), 'assignfeedback_comments', $menu));  
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:

      Description

      You should change the position of the strings in the settings for the assignment activity. Please view the screenshot.

      string['feedbackpluginforgradebook'] = 'Feedback plugin that will push comments to the grade book';
      string['feedbackplug'] = 'Feedback plugin';

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            krause Ralf Krause added a comment -

            change the sting positions

            Show
            krause Ralf Krause added a comment - change the sting positions
            Hide
            fred Frédéric Massart added a comment -

            Thanks Damyon! Pushing for integration now.

            Show
            fred Frédéric Massart added a comment - Thanks Damyon! Pushing for integration now.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Sneaking this into integration ... shh ...

            Show
            samhemelryk Sam Hemelryk added a comment - Sneaking this into integration ... shh ...
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks guys, a simple change with no risk hence I snuck it into integration, and it has now been integrated.

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks guys, a simple change with no risk hence I snuck it into integration, and it has now been integrated.
            Hide
            timb Tim Barker added a comment -

            Congratulations your fix has passed testing

            Show
            timb Tim Barker added a comment - Congratulations your fix has passed testing
            Hide
            poltawski Dan Poltawski added a comment -

            *Notice*: Undefined variable: friendlyintegrator in /Users/danp/git/tokenintegrationthanks.php on line 26

            Congratulations

            {tracker.user.name}

            !

            You've made into Moodle

            {tracker.fixversion-1}

            +

            I would like to personally thank you for this contribution on behalf of all Moodle users throughout the world.

            cheers!

            {tracker.friendlyintegrator}
            Show
            poltawski Dan Poltawski added a comment - * Notice *: Undefined variable: friendlyintegrator in /Users/danp/git/tokenintegrationthanks.php on line 26 Congratulations {tracker.user.name} ! You've made into Moodle {tracker.fixversion-1} + I would like to personally thank you for this contribution on behalf of all Moodle users throughout the world. cheers! {tracker.friendlyintegrator}

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Sep/12