Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.5
    • Component/s: RSS
    • Labels:
    • Rank:
      42563

      Description

      Its just been released, php5 only:

      http://simplepie.org/blog/2012/07/07/one-dot-three/

      Main barrier will be: "One of the most important changes is that the SimplePie constructor no longer supports arguments."

        Issue Links

          Activity

          Hide
          Dan Poltawski added a comment -

          Also need to investigate the various encoding issues and see if we can solve them with this release.

          Show
          Dan Poltawski added a comment - Also need to investigate the various encoding issues and see if we can solve them with this release.
          Hide
          Frédéric Massart added a comment -

          Hi Dan, following some research for MDL-28633, here a patch that I have used to import the new version of SimplePie (I have added some comment on Github).
          https://github.com/FMCorz/moodle/commit/8d1116c636d7baac282fa613bb11f8d6218a9af0

          Show
          Frédéric Massart added a comment - Hi Dan, following some research for MDL-28633 , here a patch that I have used to import the new version of SimplePie (I have added some comment on Github). https://github.com/FMCorz/moodle/commit/8d1116c636d7baac282fa613bb11f8d6218a9af0
          Hide
          Edith Speller added a comment -

          Hi,

          I'm interested in this task because it seems to be linked with solving bug MDL-28633 which has broken our whole implementation of reading lists at our site since the upgrade to 2.1. I'm confused as the bug is listed as a Major priority while this task is listed as Minor priority, which seems like a mis-match.

          I see Frederic has posted a patch - is this something sites can use now, or do they have to wait for a packaged release? My site is hosted by the ULCC (University of London Computing Centre).

          Thanks.

          Show
          Edith Speller added a comment - Hi, I'm interested in this task because it seems to be linked with solving bug MDL-28633 which has broken our whole implementation of reading lists at our site since the upgrade to 2.1. I'm confused as the bug is listed as a Major priority while this task is listed as Minor priority, which seems like a mis-match. I see Frederic has posted a patch - is this something sites can use now, or do they have to wait for a packaged release? My site is hosted by the ULCC (University of London Computing Centre). Thanks.
          Hide
          Dan Poltawski added a comment -

          Hi Edith,

          I'm afraid I would not recommend applying Freds patch at this time.

          Show
          Dan Poltawski added a comment - Hi Edith, I'm afraid I would not recommend applying Freds patch at this time.
          Hide
          Dan Poltawski added a comment -

          Fred, do you feel like taking this one?

          Show
          Dan Poltawski added a comment - Fred, do you feel like taking this one?
          Hide
          Dan Poltawski added a comment -

          git git://github.com/FMCorz/moodle/ MDL-34222-master

          Show
          Dan Poltawski added a comment - git git://github.com/FMCorz/moodle/ MDL-34222 -master
          Hide
          Petr Škoda added a comment -

          Looks like I managed to hack it, so far it works fine for me...

          Show
          Petr Škoda added a comment - Looks like I managed to hack it, so far it works fine for me...
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks!
          (I've added one extra commit fixing permissions)

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated, thanks! (I've added one extra commit fixing permissions)
          Hide
          David Monllaó added a comment -

          It passes

          Show
          David Monllaó added a comment - It passes
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Your awesome contributions are now part of Moodle, your fav LMS out there.

          Closing this as fixed.

          Many thanks for all the hard work, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Your awesome contributions are now part of Moodle, your fav LMS out there. Closing this as fixed. Many thanks for all the hard work, ciao

            People

            • Votes:
              2 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: