-
Bug
-
Resolution: Fixed
-
Minor
-
2.3, 2.3.2
-
MOODLE_23_STABLE
-
MOODLE_23_STABLE
-
MDL-34228-master -
Since commit MDL-32107
https://github.com/moodle/moodle/commit/38d06fea66063ca6574a473eec2904ac11912608
the completion report has silently stopped filtering by gradebookroles (used to be called progresstrackedroles, it's a configuration setting).
The reason is that the method get_tracked_user_sql() has been eliminated from the completion_info class in completionlib.php in favor of get_enrolled_sql() in lib/accesslib. But they are different functions.
Only grade report now filters by gradebookroles.
If that configuration exists, there is a reason.
Or not?
It is useful to me, and maybe other Moodle admins are already using it.
We need to create precise reports for sending to specific authorities and need to control who is included.
And however, while it exists, it should be used.
When it is replaced by something, we can use that alternative.
I know it has been proposed to create a capability 'info/included_in_reports', but 'being included in reports' is not really a capability, like seeing reports is.
Plus Moodle functionality shouldn't just silently change.
I think it would be useful to be able to have a completion report that is consistent with the gradebook report. If people want other roles included in the report, they can always add them to gradebookroles.
Thank you all for the great work and that you for Moodle.