Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34228

Completion report no longer filter by roles (gradebookroles)

    Details

    • Testing Instructions:
      Hide

      NOTE: This test assumes you create a new course and activity. Alternatively, using existing ones will be fine.

      0. Enable completion tracking at system level if necessary.
      1. Set up a new course and enable completion tracking under 'Student progress'.
      2. Create a new Page and set the completion option to 'manual'.
      3. Enrol two users in the course: one as a student (I'm calling this one U1) and one as a teacher (I'm calling this one U2).
      4. View the activity completion report for the course (under Reports / Activity completion in Navigation).
      + The student U1 should display in the report.
      + The teacher U2 should not display in the report.

      5. Under the course settings, go to Users/Permissions.
      6. Look for 'iscompletiontracked'.
      + Currently (default) it is allocated to Student role.

      7. Click the + icon and add the capability to the Teacher role.
      8. Reload the activity completion reports.
      + Now both users should display on the report.

      Show
      NOTE: This test assumes you create a new course and activity. Alternatively, using existing ones will be fine. 0. Enable completion tracking at system level if necessary. 1. Set up a new course and enable completion tracking under 'Student progress'. 2. Create a new Page and set the completion option to 'manual'. 3. Enrol two users in the course: one as a student (I'm calling this one U1) and one as a teacher (I'm calling this one U2). 4. View the activity completion report for the course (under Reports / Activity completion in Navigation). + The student U1 should display in the report. + The teacher U2 should not display in the report. 5. Under the course settings, go to Users/Permissions. 6. Look for 'iscompletiontracked'. + Currently (default) it is allocated to Student role. 7. Click the + icon and add the capability to the Teacher role. 8. Reload the activity completion reports. + Now both users should display on the report.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-34228-master

      Description

      Since commit MDL-32107
      https://github.com/moodle/moodle/commit/38d06fea66063ca6574a473eec2904ac11912608
      the completion report has silently stopped filtering by gradebookroles (used to be called progresstrackedroles, it's a configuration setting).
      The reason is that the method get_tracked_user_sql() has been eliminated from the completion_info class in completionlib.php in favor of get_enrolled_sql() in lib/accesslib. But they are different functions.

      Only grade report now filters by gradebookroles.
      If that configuration exists, there is a reason.
      Or not?
      It is useful to me, and maybe other Moodle admins are already using it.
      We need to create precise reports for sending to specific authorities and need to control who is included.

      And however, while it exists, it should be used.
      When it is replaced by something, we can use that alternative.

      I know it has been proposed to create a capability 'info/included_in_reports', but 'being included in reports' is not really a capability, like seeing reports is.

      Plus Moodle functionality shouldn't just silently change.

      I think it would be useful to be able to have a completion report that is consistent with the gradebook report. If people want other roles included in the report, they can always add them to gradebookroles.

      Thank you all for the great work and that you for Moodle.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  8 Vote for this issue
                  Watchers:
                  7 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    12/Nov/12