Moodle
  1. Moodle
  2. MDL-34234

Error when trying to drag and drop a resource into a course in an upgraded site

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.3.1, 2.4
    • Fix Version/s: 2.3.3
    • Component/s: Course
    • Labels:
    • Rank:
      42577

      Description

      I found when trying to drag and drop resources into a course the resources would be successfully added but the loading icon would be displayed until I refreshed the page.
      I checked the XHR request and found the following preceding the JSON response.

      <b>Notice</b>: Undefined property: stdClass::$showsize in <b>/var/www/integration/mod/resource/lib.php</b> on line <b>515</b><br />
      <br />
      <b>Notice</b>: Undefined property: stdClass::$showtype in <b>/var/www/integration/mod/resource/lib.php</b> on line <b>516</b><br />

      After browsing to Site Administration > Plugins > Activity modules > File and saving the form without making changes things returned to normal, obviously during the upgrade I must have missed the settings update so likely just a case of checking isset in that function to cover missed upgrade steps.

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          This might explain some un-replicatable issues that have been coming in lately. (Not that I can find them now.)

          Show
          Michael de Raadt added a comment - This might explain some un-replicatable issues that have been coming in lately. (Not that I can find them now.)
          Hide
          Sam Hemelryk added a comment -

          Linking to the issue that caused the regression MDL-31121.

          Show
          Sam Hemelryk added a comment - Linking to the issue that caused the regression MDL-31121 .
          Hide
          Dan Poltawski added a comment -

          +1 here Sam

          Show
          Dan Poltawski added a comment - +1 here Sam
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (23 & master), thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (23 & master), thanks!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Tested by hack-unsetting config->xxx, works perfectly if they are not set. Passing.

          Show
          Eloy Lafuente (stronk7) added a comment - Tested by hack-unsetting config->xxx, works perfectly if they are not set. Passing.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Closing as fixed, many thanks for your awesome collaboration.

          Show
          Eloy Lafuente (stronk7) added a comment - Closing as fixed, many thanks for your awesome collaboration.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: