[MDL-34240] Switch OAuth params to PARAM_RAW_TRIMMED - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

Enable portfolios

Add the googledocs repo plugin

Add into the client id/secret fields ' t@$s|t ' (including the spaces but not including ').

View the googledocs plugin settings

VERIFY: that the clientid/secret fields do not have leading/trailing spaces

VERIFY: that the cliendid/secret fields DO have the symbols etc.

REPEAT: for picasa repository plugin

REPEAT: for googledocs portfolio plugin

REPEAT: for picasa portfolio plugin
Show
Enable portfolios Add the googledocs repo plugin Add into the client id/secret fields ' t@$s|t ' (including the spaces but not including '). View the googledocs plugin settings VERIFY: that the clientid/secret fields do not have leading/trailing spaces VERIFY: that the cliendid/secret fields DO have the symbols etc. REPEAT: for picasa repository plugin REPEAT: for googledocs portfolio plugin REPEAT: for picasa portfolio plugin
Affected Branches:
MOODLE_23_STABLE
Fixed Branches:
MOODLE_23_STABLE
Pull from Repository:
git://github.com/danpoltawski/moodle.git
Pull Master Branch:
~~MDL-34240~~
Pull Master Diff URL:
https://github.com/danpoltawski/moodle/compare/MDL-34240

People are copying and pasting values into the oauth credentials boxes and ending up with trailing whitespace breaking it.

To prevent these problems, we should use PARAM_RAW_TRIMMED

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan