Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34240

Switch OAuth params to PARAM_RAW_TRIMMED

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Enable portfolios
      2. Add the googledocs repo plugin
      3. Add into the client id/secret fields ' t@$s|t ' (including the spaces but not including ').
      4. View the googledocs plugin settings
      5. VERIFY: that the clientid/secret fields do not have leading/trailing spaces
      6. VERIFY: that the cliendid/secret fields DO have the symbols etc.
      7. REPEAT: for picasa repository plugin
      8. REPEAT: for googledocs portfolio plugin
      9. REPEAT: for picasa portfolio plugin
      Show
      Enable portfolios Add the googledocs repo plugin Add into the client id/secret fields ' t@$s|t ' (including the spaces but not including '). View the googledocs plugin settings VERIFY: that the clientid/secret fields do not have leading/trailing spaces VERIFY: that the cliendid/secret fields DO have the symbols etc. REPEAT: for picasa repository plugin REPEAT: for googledocs portfolio plugin REPEAT: for picasa portfolio plugin
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:

      Description

      People are copying and pasting values into the oauth credentials boxes and ending up with trailing whitespace breaking it.

      To prevent these problems, we should use PARAM_RAW_TRIMMED

        Attachments

          Activity

            People

            Assignee:
            poltawski Dan Poltawski
            Reporter:
            poltawski Dan Poltawski
            Integrator:
            Sam Hemelryk
            Tester:
            Rajesh Taneja
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              10/Sep/12