Moodle
  1. Moodle
  2. MDL-34240

Switch OAuth params to PARAM_RAW_TRIMMED

        Details

        • Testing Instructions:
          Hide
          1. Enable portfolios
          2. Add the googledocs repo plugin
          3. Add into the client id/secret fields ' t@$s|t ' (including the spaces but not including ').
          4. View the googledocs plugin settings
          5. VERIFY: that the clientid/secret fields do not have leading/trailing spaces
          6. VERIFY: that the cliendid/secret fields DO have the symbols etc.
          7. REPEAT: for picasa repository plugin
          8. REPEAT: for googledocs portfolio plugin
          9. REPEAT: for picasa portfolio plugin
          Show
          Enable portfolios Add the googledocs repo plugin Add into the client id/secret fields ' t@$s|t ' (including the spaces but not including '). View the googledocs plugin settings VERIFY: that the clientid/secret fields do not have leading/trailing spaces VERIFY: that the cliendid/secret fields DO have the symbols etc. REPEAT: for picasa repository plugin REPEAT: for googledocs portfolio plugin REPEAT: for picasa portfolio plugin
        • Affected Branches:
          MOODLE_23_STABLE
        • Fixed Branches:
          MOODLE_23_STABLE
        • Pull from Repository:
        • Pull Master Branch:
        • Pull Master Diff URL:

          Description

          People are copying and pasting values into the oauth credentials boxes and ending up with trailing whitespace breaking it.

          To prevent these problems, we should use PARAM_RAW_TRIMMED

            Gliffy Diagrams

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Sam Hemelryk added a comment -

              Thanks Dan, changes look good and have been integrated now.

              Show
              Sam Hemelryk added a comment - Thanks Dan, changes look good and have been integrated now.
              Hide
              Permalink
              Rajesh Taneja added a comment -

              Works Grt,

              Thanks for fixing this Dan.

              FYI:
              We might want to give same love to Box.net, flickr etc.

              Show
              Rajesh Taneja added a comment - Works Grt, Thanks for fixing this Dan. FYI: We might want to give same love to Box.net, flickr etc.
              Hide
              Permalink
              Dan Poltawski added a comment -

              *Notice*: Undefined variable: friendlyintegrator in /Users/danp/git/tokenintegrationthanks.php on line 26

              Congratulations

              {tracker.user.name}

              !

              You've made into Moodle

              {tracker.fixversion-1}

              +

              I would like to personally thank you for this contribution on behalf of all Moodle users throughout the world.

              cheers!

              {tracker.friendlyintegrator}
              Show
              Dan Poltawski added a comment - * Notice *: Undefined variable: friendlyintegrator in /Users/danp/git/tokenintegrationthanks.php on line 26 Congratulations {tracker.user.name} ! You've made into Moodle {tracker.fixversion-1} + I would like to personally thank you for this contribution on behalf of all Moodle users throughout the world. cheers! {tracker.friendlyintegrator}

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: