This doesn't occurring during normal use of course completion, but could be a problem if people have customised completion.

Hi Aaron,

I was just looking at this change (checking over issues for the next integration run) and ran a quick grep on master (grep -Frn 'completion_criteria::factory' .).
I see there are 3 calls to that static factory method, 2 of which appear to pass objects and 1 that passes and array.

./lib/completionlib.php:366:                $this->criteria[$record->id] = completion_criteria::factory((array)$record);

./lib/completion/completion_criteria_completion.php:152:            $this->attach_criteria(completion_criteria::factory($record));

./course/togglecompletion.php:56:        completion_criteria::factory((object) array('id'=>$rolec, 'criteriatype'=>COMPLETION_CRITERIA_TYPE_ROLE)); //TODO: this is dumb, because it does not fetch the data?!?!

Looks like the ./course/togglecompletion.php script needs to be updated as well.
Perhaps its worth producing separate stable branches and adding an array type hint to the factory method in master only to ensure future calls are made correctly.

Cheers
Sam

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Thanks Aaron, this has been integrated now.

I had a think about togglecompletion.php and decided it would be easiest to fix it during integration.
As such I made an additional commit (9df8150) and then backported both your commit and my own to 23, and 22.

Cheers
Sam

Hi Aaron,

Could you provide testing instructions for this issue?

Thanks.

Hi,

Added the best instructions I can, these will make sure that this patch doesn't cause any regressions.

Cheers,
Aaron

This looks good.

Thanks Aaron.

Test passed.

yay, it works!

This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.

Thank you all for taking the time to get us here.

cheers!