Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34255

Students can't add group events to calendar (user events created instead)

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.1
    • Fix Version/s: 2.2.5, 2.3.2
    • Component/s: Calendar
    • Labels:
    • Testing Instructions:
      Hide

      Set student's capability:

      • Settings > Course administration > Users > Permissions
      • Advanced role override: Student
      • Filter: calendar
      • moodle/calendar:managegroupentries): Allow

      Set some groups to a course and add some users to a group:

      • course admin > users > groups

      As student, create group event.
      As teacher, check the calendar and make sure they can view and edit the group event.

      Show
      Set student's capability: Settings > Course administration > Users > Permissions Advanced role override: Student Filter: calendar moodle/calendar:managegroupentries): Allow Set some groups to a course and add some users to a group: course admin > users > groups As student, create group event. As teacher, check the calendar and make sure they can view and edit the group event.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      We used to be able to do this in M1.9. We're currently running M2.2.

      Our M1.9 documentation reads:


      Requirements: Students need to be able to add events to the course calendar. The teacher needs to view student calendar entries. Students may view each others' entries.

      Solution: Create a group ("Calendar") and add all the students and teacher(s). Use override permissions to give students the ability to edit group calendar entries. When the students create the calendar entries, they should be instructed to create them as "Group Event" and select the group "Calendar" from the drop-down menu.

      Assign roles > Override permissions > Student > Manage group calendar entries (moodle/calendar:managegroupentries): Allow


      In M2, the permission adjustment is now/appears to be: Settings > Course administration > Users > Permissions
      Advanced role override: Student
      Filter: calendar

      moodle/calendar:managegroupentries): Allow

      This setup no longer works in M2.2. When the student goes to add a new event, they are given the choice between creating a User or Group event (they choose Group). They are allowed to select the group (they choose Calendar). So far so good, right? But when they save the new event, it's saved as a User event. The teacher cannot see the event, other students cannot see the event.

      The Teacher is able to add a Group event successfully.

      Checking any given student's permissions, they have "Manage group calendar entries: Yes".

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            salvetore Michael de Raadt added a comment -

            Thanks for reporting that.

            Feel free to help us work on this issue.

            Show
            salvetore Michael de Raadt added a comment - Thanks for reporting that. Feel free to help us work on this issue.
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            Hi Rosie,
            Patch looks good.
            Passing.
            Thanks

            Show
            ankit_frenz Ankit Agarwal added a comment - Hi Rosie, Patch looks good. Passing. Thanks
            Hide
            rwijaya Rossiani Wijaya added a comment -

            Thanks Ankit.

            Submitting for integration review.

            Show
            rwijaya Rossiani Wijaya added a comment - Thanks Ankit. Submitting for integration review.
            Hide
            nebgor Aparup Banerjee added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            nebgor Aparup Banerjee added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks Rosie, i've integrated this now.

            Show
            poltawski Dan Poltawski added a comment - Thanks Rosie, i've integrated this now.
            Hide
            salvetore Michael de Raadt added a comment -

            Test result: Success.

            Tested in 2.2, 2.3 and master.

            I noted the effect of creating an event for a group that the student is not a member of. This is covered in MDL-34530 and I have commented in that issue.

            Show
            salvetore Michael de Raadt added a comment - Test result: Success. Tested in 2.2, 2.3 and master. I noted the effect of creating an event for a group that the student is not a member of. This is covered in MDL-34530 and I have commented in that issue.
            Hide
            poltawski Dan Poltawski added a comment -

            asko, Дзякуй, ধন্যবাদ, Благодаря, Gràcies, 感谢, 謝謝, Hvala, Díky, Tak, Bedankt, Tänan, متشکریم, Salamat, Kiitokset, Merci, Grazas, Danke, Ευχαριστώ, આભાર, תודה, धन्यवाद, Köszönjük, Takk fyrir, Terima Kasih, Grazie, ありがとうございます, Рахмет, សូមអរគុណ, 감사합니다, gratiās, Pateicamies, Ačiū, Благодарам, Tēnā koa, Kia Ora Rawa Atu, आभारी आहोत, Талархал, Takk, Dziękuję, Obrigado, Mulţumesc, Engraziel, Спасибо, Fa'afetai, Хвала, Hvala, ස්තූතියි, Vďaka, Hvala, Mahadsanid, Thanks, Gracias, Tack, Salamat, நன்றி, నెనరులు, ขอบคุณค่ะ!

            Your work has made it into this weeks Moodle release! There are no gold medals available this week - but millions around the world will benefit. Thank you!

            Show
            poltawski Dan Poltawski added a comment - asko, Дзякуй, ধন্যবাদ, Благодаря, Gràcies, 感谢, 謝謝, Hvala, Díky, Tak, Bedankt, Tänan, متشکریم, Salamat, Kiitokset, Merci, Grazas, Danke, Ευχαριστώ, આભાર, תודה, धन्यवाद, Köszönjük, Takk fyrir, Terima Kasih, Grazie, ありがとうございます, Рахмет, សូមអរគុណ, 감사합니다, gratiās, Pateicamies, Ačiū, Благодарам, Tēnā koa, Kia Ora Rawa Atu, आभारी आहोत, Талархал, Takk, Dziękuję, Obrigado, Mulţumesc, Engraziel, Спасибо, Fa'afetai, Хвала, Hvala, ස්තූතියි, Vďaka, Hvala, Mahadsanid, Thanks, Gracias, Tack, Salamat, நன்றி, నెనరులు, ขอบคุณค่ะ! Your work has made it into this weeks Moodle release! There are no gold medals available this week - but millions around the world will benefit. Thank you!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Sep/12