Moodle
  1. Moodle
  2. MDL-34256

"Requires Grading" filter shows students with no assignment submission (2.3 Assignment Module)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3.2
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Create an assignment with at least one submission type in a course with students
      2. Go to the assignment grading table
      3. Change the filter to "Requires grading"
      4. Verify that no students appear in the list (because no-one as submitted anything)
      5. Edit the assignment settings and set "Online text" and "File submissions" in the Submission settings to "No"
      6. Go to the assignment grading table
      7. Verify that the filter is completely removed (The current list of filters don't make sense with no submissions)
      Show
      Create an assignment with at least one submission type in a course with students Go to the assignment grading table Change the filter to "Requires grading" Verify that no students appear in the list (because no-one as submitted anything) Edit the assignment settings and set "Online text" and "File submissions" in the Submission settings to "No" Go to the assignment grading table Verify that the filter is completely removed (The current list of filters don't make sense with no submissions)
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
    • Rank:
      42605

      Description

      The "Requires grading" filter in the 2.2 assignment module would only show the student submissions that require grading. This was correct. In the updated assignment module (2.3) this filter now includes students with no assignment submission. This makes locating assignments that require grading difficult in a course with 100+ students.

      Example: http://img11.imageshack.us/img11/4465/requiresgradingfilter23.jpg

        Activity

        Hide
        Michael de Raadt added a comment -

        Thanks for reporting this.

        I've put that on the backlog.

        In the meantime feel free to help us work on this issue. If you are able to provide a patch or links to your Git repository branch, please add a patch label so we will spot it.

        Show
        Michael de Raadt added a comment - Thanks for reporting this. I've put that on the backlog. In the meantime feel free to help us work on this issue. If you are able to provide a patch or links to your Git repository branch, please add a patch label so we will spot it.
        Hide
        Adrian Greeve added a comment -

        Hi Damyon,

        The code for this patch looks good.

        I did have one problem when running through the testing instructions. Step five had me scratching my head a bit as to what to do. Perhaps they could be expanded a bit to something like:

        • Edit the assignment settings and set "Online text" and "File submissions" in the Submission settings to "No"
        Show
        Adrian Greeve added a comment - Hi Damyon, The code for this patch looks good. I did have one problem when running through the testing instructions. Step five had me scratching my head a bit as to what to do. Perhaps they could be expanded a bit to something like: Edit the assignment settings and set "Online text" and "File submissions" in the Submission settings to "No"
        Hide
        Damyon Wiese added a comment -

        Thanks Adrian,

        I've updated the testing instructions as described.

        Regards, Damyon

        Show
        Damyon Wiese added a comment - Thanks Adrian, I've updated the testing instructions as described. Regards, Damyon
        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Sam Hemelryk added a comment -

        Thanks Damyon, changes looked spot on and have been integrated now

        Show
        Sam Hemelryk added a comment - Thanks Damyon, changes looked spot on and have been integrated now
        Hide
        Tim Barker added a comment -

        Congrats, the test passed.

        Show
        Tim Barker added a comment - Congrats, the test passed.
        Hide
        Aparup Banerjee added a comment -

        yay, it works!

        This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.

        Thank you all for taking the time to get us here.

        cheers!

        Show
        Aparup Banerjee added a comment - yay, it works! This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week. Thank you all for taking the time to get us here. cheers!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: