Moodle
  1. Moodle
  2. MDL-34265

Can not sort by response in SCORM Interactions report

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.2.5, 2.3.2
    • Component/s: SCORM
    • Labels:
    • Testing Instructions:
      Hide
      1. Upload a scorm pack
      2. Login as a student and submit a few responses.
      3. As a teacher/admin view the interactions report for scorm (Scorm>report>interaction)
      4. check the boxes summary of questions,answers,right answers and save
      5. Make sure the columns corresponding to questions,answers and right answers are not sortable.
      Show
      Upload a scorm pack Login as a student and submit a few responses. As a teacher/admin view the interactions report for scorm (Scorm>report>interaction) check the boxes summary of questions,answers,right answers and save Make sure the columns corresponding to questions,answers and right answers are not sortable.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-34265-master
    • Rank:
      42617

      Description

      When viewing the interactions report in a SCORM module, clicking on the table header labelled Response0 e.t.c. will result in the following error being produced.

      Unknown column 'response0' in 'order clause'

        Activity

        Hide
        Dan Marsden added a comment -

        bouncing this one through to Ankit

        Show
        Dan Marsden added a comment - bouncing this one through to Ankit
        Hide
        Ankit Agarwal added a comment -

        I don't see anyway of making these columns sortable. So the patch removes sorting flag from these columns.
        Requesting a review.
        Thanks

        Show
        Ankit Agarwal added a comment - I don't see anyway of making these columns sortable. So the patch removes sorting flag from these columns. Requesting a review. Thanks
        Hide
        Dan Marsden added a comment -

        looks good to me - bouncing up for integration.

        Show
        Dan Marsden added a comment - looks good to me - bouncing up for integration.
        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Ankit Agarwal added a comment -

        rebased.
        Thanks

        Show
        Ankit Agarwal added a comment - rebased. Thanks
        Hide
        Sam Hemelryk added a comment -

        Thanks Ankit. This has been integrated now

        Show
        Sam Hemelryk added a comment - Thanks Ankit. This has been integrated now
        Hide
        Frédéric Massart added a comment -

        Test passed on 2.2, 2.3 and master. \o/

        Show
        Frédéric Massart added a comment - Test passed on 2.2, 2.3 and master. \o/
        Hide
        Aparup Banerjee added a comment -

        yay, it works!

        This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.

        Thank you all for taking the time to get us here.

        cheers!

        Show
        Aparup Banerjee added a comment - yay, it works! This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week. Thank you all for taking the time to get us here. cheers!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: