Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34291

Inconsistent markup for error, warning, OK spans

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.3
    • Fix Version/s: None
    • Component/s: Themes
    • Labels:
    • Affected Branches:
      MOODLE_23_STABLE

      Description

      There's a few different ways in which Moodle marks up short status messages e.g. I've found the following,

      span.ok,
      span.statusok,
      span.error,
      span.warn,
      span.statuswarning,
      font[color="green"]

      and I'm guessing there's more about e.g. font red for warnings.

      I'd suggest standardizing on the format used by Twitter's Bootstrap and then re-using their CSS:

      http://twitter.github.com/bootstrap/components.html#labels

      Once that's done there's other occasions were re-using this same markup might be useful e.g. if you override things in the config.php we could use span.label.label-warning etc.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              moodle.com moodle.com
              Reporter:
              bawjaws David Scotson
              Participants:
              Component watchers:
              Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated: