Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34292

generic class and unique identifier for tabular tables

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.3
    • Fix Version/s: None
    • Component/s: Themes
    • Labels:
      None
    • Affected Branches:
      MOODLE_23_STABLE

      Description

      In HTML it's common to use the table tag, not for tables for laying out a page. This makes it difficult to style actual tables of data without unexpected side-effects.

      It would be useful if each actual table of data in the Moodle interface had a tag to identify it as such. I think this is the concept behind the .generaltable class, but I'm not sure, and I'm not sure that people who use it are sure either. I'd propose that we adopt the same naming scheme as Twitter's Bootstrap (http://twitter.github.com/bootstrap/base-css.html#tables) and add a .table class to each table being used as a table. And also adopt their CSS.

      It would also be useful if each table had a specific class name so that it could be specifically targetted. This is sporadically done at the moment, some have css ids, some have classes, but many can only be targetted by the id or class of the containing page, and even then sometimes you can't pinpoint one table and hit two tables shown on different tabs. It would be good if we standardised on a class name scheme e.g. the config changes report tables in admin could be table class="table configchanges" and then be targetted as .configchanges.table in the CSS.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              bawjaws David Scotson
              Participants:
              Component watchers:
              Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated: