Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34293

Table headings inside the tbody rather than the thead section

XMLWordPrintable

    • MOODLE_23_STABLE
    • MOODLE_24_STABLE
    • wip-mdl-34293
    • Hide

      Prerequisite:
      You need firebug or able to see page source.

      Test:
      visit tables on these pages:
      table#modules /admin/modules.php
      table#partipants /user/index.php?id=1
      table.compatibleblockstable /admin/blocks.php

      Make sure first row in the table containing headers should be wrapped in <thead> tags and rest in <tbody>

      Show
      Prerequisite: You need firebug or able to see page source. Test: visit tables on these pages: table#modules /admin/modules.php table#partipants /user/index.php?id=1 table.compatibleblockstable /admin/blocks.php Make sure first row in the table containing headers should be wrapped in <thead> tags and rest in <tbody>

      Some tables in Moodle put the table heading inside the tbody section rather than the thead. As well as being incorrect, this has at least two pragmatic effects. 1) It makes Moodle harder to theme, 2) it affects accessability.

      Some examples are:

      table#modules /admin/modules.php
      table#partipants /user/index.php?id=1
      table.compatibleblockstable /admin/blocks.php
      table.minicalendar /calendar/view.php?view=month&cal_d=1&cal_m=7&cal_y=2012&course=1

      There might be more, adding the following lines to a theme should highlight the issue as you browse the site, the second line hides a common false positive for vertical tables with headers as the left column:

      table tbody tr th

      {border: thick solid green !important; }

      table tbody tr th:first-child

      {border: none !important;}

            rajeshtaneja Rajesh Taneja
            bawjaws David Scotson
            Frédéric Massart Frédéric Massart
            Dan Poltawski Dan Poltawski
            Ankit Agarwal Ankit Agarwal
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.