Moodle
  1. Moodle
  2. MDL-34298

Search Courses box doesn't validate as HTML5 / potential accessibilty problem

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3, 2.4.1, 2.5
    • Fix Version/s: 2.3.5, 2.4.2
    • Component/s: Navigation
    • Labels:
    • Rank:
      42664

      Description

      The Search Courses box doesn't validate as HTML5 because it seems you can no longer use alt on an input unless it is an image used as a button. The alt text seems to duplicate the normal text displayed beside it so if it is being read by accessible tools then they're getting duplicate info which is an accessibility issue. So either way I think the alt text should be removed from this input element.

        Activity

        Hide
        Sam Hemelryk added a comment -

        Thanks for reporting that David.

        Having just being looking at it I can see that in fact the alt attribute is entirely redundant as the exact same content is used within the label for the input.

        I've created a patch for this and am putting it up for integration straight away.

        Show
        Sam Hemelryk added a comment - Thanks for reporting that David. Having just being looking at it I can see that in fact the alt attribute is entirely redundant as the exact same content is used within the label for the input. I've created a patch for this and am putting it up for integration straight away.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated (23, 14 & master), thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated (23, 14 & master), thanks!
        Hide
        Rossiani Wijaya added a comment -

        This is working as expected.

        Tested for 2.3, 2.4 and master.

        Test passed.

        Show
        Rossiani Wijaya added a comment - This is working as expected. Tested for 2.3, 2.4 and master. Test passed.
        Hide
        Damyon Wiese added a comment -

        Thanks for your hard work - this issue has made it! Moodle is now a little bit better.

        Regards, Damyon

        Show
        Damyon Wiese added a comment - Thanks for your hard work - this issue has made it! Moodle is now a little bit better. Regards, Damyon

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: