Moodle
  1. Moodle
  2. MDL-34300

chooserdialogue doesn't set zindex correctly (YUI issue)

    Details

    • Testing Instructions:
      Hide
      • Open a course
      • Turn editing on
      • Open the activity chooser
      • Inspect the dialogue
      • Find the wrapping div for chooserdialogue
        • Ensure that no z-index is set explicitly on the element
        • Ensure that a z-index is set from the style sheet
      Show
      Open a course Turn editing on Open the activity chooser Inspect the dialogue Find the wrapping div for chooserdialogue Ensure that no z-index is set explicitly on the element Ensure that a z-index is set from the style sheet
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
    • Rank:
      42667

      Description

      We currently don't set a zIndex explicitly on the chooserdialogue (though this is by a casing accident really), but a zIndex or 0 is applied.

      We either need to work around this, or get it fixed in upstream YUI as it prevents us from applying z-index changes in any Y.Panel, Y.Overlay, or Y.Widget.

      See YUI bug: http://yuilibrary.com/projects/yui3/ticket/2532507

        Issue Links

          Activity

          Hide
          Andrew Nicols added a comment -

          I've found a way of working around this in YUI. As a result, I've been able to remove the !important from the CSS which will help resolve another issue with z-index on the new tooltips.

          Show
          Andrew Nicols added a comment - I've found a way of working around this in YUI. As a result, I've been able to remove the !important from the CSS which will help resolve another issue with z-index on the new tooltips.
          Hide
          Andrew Nicols added a comment -

          Intended only for master.

          Show
          Andrew Nicols added a comment - Intended only for master.
          Hide
          Sam Hemelryk added a comment -

          Linking MDL-38067 as it is blocked by this issue.

          Show
          Sam Hemelryk added a comment - Linking MDL-38067 as it is blocked by this issue.
          Hide
          Sam Hemelryk added a comment -

          Code looks perfect thanks Andrew.

          Great thank you linked to the ticket and that you were able to remove a !important from CSS (I hate those with a passion).

          Feel free to push to integration when you are ready.

          Many thanks
          Sam

          Show
          Sam Hemelryk added a comment - Code looks perfect thanks Andrew. Great thank you linked to the ticket and that you were able to remove a !important from CSS (I hate those with a passion). Feel free to push to integration when you are ready. Many thanks Sam
          Hide
          Aparup Banerjee added a comment -

          i wondered about back-portability but then i thought production themes might get mushy (possibly).

          Anyway thanks, integrated into master only.

          Show
          Aparup Banerjee added a comment - i wondered about back-portability but then i thought production themes might get mushy (possibly). Anyway thanks, integrated into master only.
          Hide
          Frédéric Massart added a comment -

          Passed, thanks!

          Show
          Frédéric Massart added a comment - Passed, thanks!
          Hide
          Mary Evans added a comment -

          Cheers

          Show
          Mary Evans added a comment - Cheers
          Hide
          Eloy Lafuente (stronk7) added a comment -

          This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities.

          Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied).

          Thanks, closing as fixed!

          Show
          Eloy Lafuente (stronk7) added a comment - This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities. Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied). Thanks, closing as fixed!

            People

            • Votes:
              12 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: