Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34321

Assignment only partially disappears when Teacher using role switch to Student submits assignment

    Details

    • Testing Instructions:
      Hide

      As a teacher (not an admin)

      Test 1:

      1. Create an Assignment: Advanced Uploading of Files
      2. Switch role to Student.
      3. Submit some files and 'send for marking'
      4. Return to normal role
      5. Ensure it says "No attempts have been made on this assignment"

      Test 2:

      1. Create an Assignment: Single Upload
      2. Switch role to Student.
      3. Submit some files and 'send for marking'
      4. Return to normal role
      5. Ensure it says "No attempts have been made on this assignment"
      Show
      As a teacher (not an admin) Test 1: Create an Assignment: Advanced Uploading of Files Switch role to Student. Submit some files and 'send for marking' Return to normal role Ensure it says "No attempts have been made on this assignment" Test 2: Create an Assignment: Single Upload Switch role to Student. Submit some files and 'send for marking' Return to normal role Ensure it says "No attempts have been made on this assignment"
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-34321-master
    • Sprint:
      FRONTEND Sprint 7
    • Story Points (Obsolete):
      8
    • Sprint:
      FRONTEND Sprint 7

      Description

      When using Assignment: Advanced Uploading of File, I switched my role to Student (I have, normally, Course Creator and Teacher roles). I submitted an assignment as a test. I usually use a dedicated fake student account for this task, but did not at this point. I successfully uploaded an assignment in this state. Because of the assignment settings, I (as a student) am not able to modify the assignment after it was 'sent for marking.' However, now all teachers see that there's "1 submitted assignment" yet my submission appears no where else. When clicking "View 1 submitted assignment," for instance, the list is empty.

      This is a minor inconvenience, and nothing more. I checked and a regular student assignment submission appears as normal.

      To test:

      1. Create an Assignment: Advanced Uploading of Files
      2. Switch role to Student.
      3. Submit some files and 'send for marking'
      4. Return to normal role
      5. Click "View 1 submitted assignment." Verify assignment does not appear.

        Gliffy Diagrams

          Activity

          Hide
          salvetore Michael de Raadt added a comment -

          Thanks for reporting that.

          The function that counts submissions is counting correctly based on the submissions in the database, but the table is not including users who are not enrolled as students (with the permission to submit that teachers don't have) in the course. It could be possible to have the same permission restriction performed on the count.

          Show
          salvetore Michael de Raadt added a comment - Thanks for reporting that. The function that counts submissions is counting correctly based on the submissions in the database, but the table is not including users who are not enrolled as students (with the permission to submit that teachers don't have) in the course. It could be possible to have the same permission restriction performed on the count.
          Hide
          rwijaya Rossiani Wijaya added a comment -

          This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue.

          Show
          rwijaya Rossiani Wijaya added a comment - This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue.
          Hide
          damyon Damyon Wiese added a comment -

          Looks good to me.

          [Y] Syntax
          [Y] Whitespace
          [-] Output
          [-] Language
          [-] Databases
          [Y] Testing (instructions and automated tests)
          [-] Security
          [-] Documentation
          [Y] Git
          [-] Third party code
          [Y] Sanity check

          Submitting for integration.

          Show
          damyon Damyon Wiese added a comment - Looks good to me. [Y] Syntax [Y] Whitespace [-] Output [-] Language [-] Databases [Y] Testing (instructions and automated tests) [-] Security [-] Documentation [Y] Git [-] Third party code [Y] Sanity check Submitting for integration.
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Thanks guys - this has been integrated now.

          Show
          samhemelryk Sam Hemelryk added a comment - Thanks guys - this has been integrated now.
          Hide
          fred Frédéric Massart added a comment -

          Passing. Thanks!

          Show
          fred Frédéric Massart added a comment - Passing. Thanks!
          Hide
          damyon Damyon Wiese added a comment -

          Twas the week before Christmas,
          And all though HQ
          Devs were scrambling to finish peer review.
          They sent all their issues,
          and rushed out the door -
          "To the beach!" someone heard them roar!

          This issue has been released upstream. Thanks!

          Show
          damyon Damyon Wiese added a comment - Twas the week before Christmas, And all though HQ Devs were scrambling to finish peer review. They sent all their issues, and rushed out the door - "To the beach!" someone heard them roar! This issue has been released upstream. Thanks!

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Jan/14

                Agile