Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34322

Navigation block should not show elements which are both empty and have no link

    XMLWordPrintable

Details

    • MOODLE_22_STABLE
    • MOODLE_22_STABLE, MOODLE_23_STABLE
    • MDL-34322-master-1
    • Hide
      • Open the site frontpage (or most other pages)
        • Confirm that the 'Site pages' link is visible and has children
      • Turn editing on
      • Edit the block settings for the navigation block
      • Change the "Generate navigation for the following" setting to "Categories and courses" and Save changes
        • Confirm that the 'Site pages' link is no longer visible
      Show
      Open the site frontpage (or most other pages) Confirm that the 'Site pages' link is visible and has children Turn editing on Edit the block settings for the navigation block Change the "Generate navigation for the following" setting to "Categories and courses" and Save changes Confirm that the 'Site pages' link is no longer visible

    Description

      It's currently possible an element in the navigation block to have no link, and have children but not display them.
      The result is a node in the navigation tree which has no link and cannot be expanded rendering it a digital paper-weight on our screens.

      In this scenario, we should not display the link as it's potentially confusing - it doesn't do anything.

      To replicate:

      • Open the site frontpage (or most other pages)
      • Turn editing on
      • Edit the block settings for the navigation block
      • Change the "Generate navigation for the following" setting to "Categories and courses" and Save changes
      • Notice that the "Site pages" link can't be expanded any more and don't link to anything

      Proposal: Not show the bleeding thing

      Attachments

        Activity

          People

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Sam Hemelryk Sam Hemelryk
            Sam Hemelryk Sam Hemelryk
            Andrew Davis Andrew Davis
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              10/Sep/12