Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34322

Navigation block should not show elements which are both empty and have no link

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      • Open the site frontpage (or most other pages)
        • Confirm that the 'Site pages' link is visible and has children
      • Turn editing on
      • Edit the block settings for the navigation block
      • Change the "Generate navigation for the following" setting to "Categories and courses" and Save changes
        • Confirm that the 'Site pages' link is no longer visible
      Show
      Open the site frontpage (or most other pages) Confirm that the 'Site pages' link is visible and has children Turn editing on Edit the block settings for the navigation block Change the "Generate navigation for the following" setting to "Categories and courses" and Save changes Confirm that the 'Site pages' link is no longer visible
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-34322-master-1
    • Pull Master Diff URL:

      Description

      It's currently possible an element in the navigation block to have no link, and have children but not display them.
      The result is a node in the navigation tree which has no link and cannot be expanded rendering it a digital paper-weight on our screens.

      In this scenario, we should not display the link as it's potentially confusing - it doesn't do anything.

      To replicate:

      • Open the site frontpage (or most other pages)
      • Turn editing on
      • Edit the block settings for the navigation block
      • Change the "Generate navigation for the following" setting to "Categories and courses" and Save changes
      • Notice that the "Site pages" link can't be expanded any more and don't link to anything

      Proposal: Not show the bleeding thing

        Attachments

          Activity

            People

            Assignee:
            dobedobedoh Andrew Nicols
            Reporter:
            dobedobedoh Andrew Nicols
            Peer reviewer:
            Sam Hemelryk
            Integrator:
            Sam Hemelryk
            Tester:
            Andrew Davis
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              10/Sep/12