Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34328

Browser Unresponsive when editing turned on for large courses Moodle 2.3+

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.3, 2.3.2
    • Fix Version/s: 2.3.3
    • Component/s: Course
    • Testing Instructions:
      Hide

      Before starting, purge are caches aggressively in browser and moodle.

      Regression tests:

      Within a course (in which you have editing rights):

      • Turn Editing Mode on
      • Drag a resource to another section
      • Drag a section to a new position
      • Drag a file in from the desktop
      • Drag the newly created resource to a new position
      • Edit the newly created resource's title (pencil icon)
      • Hide a resource or activity
      • Unhide a resource or activity
      • Toggle a resource or activity's group mode
      • Drag blocks around
      • Use the +/- icons to toggle visibility of blocks, and ensure that no drag event is initialised upon completion of the show/hide
      • Toggle visibility of a section using the eye icon
      • Toggle highlighting on a section using the lightbulb icon

      Performance improvements:

      These are quite difficult to test. The best thing I can advise is:

      • Use a restored copy of http://qa.moodle.net/course/view.php?id=2
      • Use IE
      • Open the Profiler on IE
        • Start profiling
        • Refresh the page
        • When the JS seems to have finished uipdating the page, stop profiling
        • Take a look in Tree view - dig down if you fancy
      • Compare with and without the patch
      Show
      Before starting, purge are caches aggressively in browser and moodle. Regression tests: Within a course (in which you have editing rights): Turn Editing Mode on Drag a resource to another section Drag a section to a new position Drag a file in from the desktop Drag the newly created resource to a new position Edit the newly created resource's title (pencil icon) Hide a resource or activity Unhide a resource or activity Toggle a resource or activity's group mode Drag blocks around Use the +/- icons to toggle visibility of blocks, and ensure that no drag event is initialised upon completion of the show/hide Toggle visibility of a section using the eye icon Toggle highlighting on a section using the lightbulb icon Performance improvements: These are quite difficult to test. The best thing I can advise is: Use a restored copy of http://qa.moodle.net/course/view.php?id=2 Use IE Open the Profiler on IE Start profiling Refresh the page When the JS seems to have finished uipdating the page, stop profiling Take a look in Tree view - dig down if you fancy Compare with and without the patch
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-34328-master-4

      Description

      To reproduce the problem I follow the steps below:

      1. Browser Internet Explorer 8 - version of Moodle 2.3 or 2.3.1 (Moodle 2.3+ (Build: 20120701))
      2. Standard theme applied and base moodle installed (no 3rd party modules or plugins etc)
      3. Restored Feature demo course from demo.moodle.net
      4. Visit the course as teacher or high role with editing permissions
      5. Click the "Turn on editing" button - the page is slow to load but works
      6. Repeat the restore of the same back up on the initial course (merge into course)
      7. Visit the course as teacher or high role with editing permissions
      8. Click the "Turn on editing" button

      Browser becomes unresponsive then throws message

      'A script on this page is causing Internet Explorer to run slowly etc'

      I have tried turning off AJAX for the site and to source the YUI externally but without any improvement. Only when I remove a number of activities/topic sections does it become responsive again. The same problem can be reproduced when I use other sample courses that have 20+ topic sections.

      I was able to produce on 2.3 so decide to apply latest 2.3.1 build but did not help. The same issue appears on IE9 but without message thrown by the browser. On IE9 it is unresponsive for about 30secs or so then decides to work again.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Nov/12