Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: SCORM
    • Labels:
    • Testing Instructions:
      Hide

      Add a scorm package to your course, incase you donot already have one.
      Make a few attempts as different students. (Existing attempts are fine as well)
      Goto scorm>reports>interraction as a teacher
      Export the report as text.
      make sure there is no error during download and the downloaded file contains all data correctly with correct headers in a tab separated format.

      Show
      Add a scorm package to your course, incase you donot already have one. Make a few attempts as different students. (Existing attempts are fine as well) Goto scorm>reports>interraction as a teacher Export the report as text. make sure there is no error during download and the downloaded file contains all data correctly with correct headers in a tab separated format.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-34336-master
    • Rank:
      42706

      Description

      Use the new class in lib/csvlib.class.php to export data into a csv, tsv or other delimited file.
      Examples can be found in:

      • admin/user/usre_bulk_download.php
      • grade/export/txt/grade_export_txt.php
      • lib/tablelib.php
      • mod/data/lib.php

        Issue Links

          Activity

          Hide
          Ankit Agarwal added a comment -

          @integrator

          • Master only
          • MDL-34074 must be integrated before this goes in.

          Thanks

          Show
          Ankit Agarwal added a comment - @integrator Master only MDL-34074 must be integrated before this goes in. Thanks
          Hide
          Adrian Greeve added a comment -

          Hi Ankit,

          Your changes look correct and the file still downloads as it did before. I see no problems.
          Now we just have to wait for MDL-34074 to be integrated

          Thanks.

          Show
          Adrian Greeve added a comment - Hi Ankit, Your changes look correct and the file still downloads as it did before. I see no problems. Now we just have to wait for MDL-34074 to be integrated Thanks.
          Hide
          Ankit Agarwal added a comment -

          Thanks for the review Adrian. will submit for integration once MDL-34074 is ready.

          Show
          Ankit Agarwal added a comment - Thanks for the review Adrian. will submit for integration once MDL-34074 is ready.
          Hide
          Dan Poltawski added a comment -

          It'd be great to get a +1 from Dan M for this.

          Show
          Dan Poltawski added a comment - It'd be great to get a +1 from Dan M for this.
          Hide
          Dan Marsden added a comment -

          +1

          Show
          Dan Marsden added a comment - +1
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday.

          This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody.

          This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P

          Apologizes for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday. This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody. This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P Apologizes for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao
          Hide
          Ankit Agarwal added a comment -

          rebased
          Thanks

          Show
          Ankit Agarwal added a comment - rebased Thanks
          Hide
          Aparup Banerjee added a comment -

          Thanks Ankit, that's integrated into master only.

          tester: test the anti-caching as well by making changing the csv to be downloaded and checking you get the latest.
          Caching seems to be taken care of by the csv lib \o/

          Show
          Aparup Banerjee added a comment - Thanks Ankit, that's integrated into master only. tester: test the anti-caching as well by making changing the csv to be downloaded and checking you get the latest. Caching seems to be taken care of by the csv lib \o/
          Hide
          Aparup Banerjee added a comment - - edited

          ah, This needs a missing include - Ankit's patch is imminent.

          Edit: MDL-34337 takes care of this include via basic reports. alls good no patch needed.

          Show
          Aparup Banerjee added a comment - - edited ah, This needs a missing include - Ankit's patch is imminent. Edit: MDL-34337 takes care of this include via basic reports. alls good no patch needed.
          Hide
          Andrew Davis added a comment -

          Seems to be working fine. Passing.

          Show
          Andrew Davis added a comment - Seems to be working fine. Passing.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          For the good and the bad... this is now part of Moodle and people around the world will start using it immediately, what a responsibility!

          Many thanks for your collaboration, yay!

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - For the good and the bad... this is now part of Moodle and people around the world will start using it immediately, what a responsibility! Many thanks for your collaboration, yay! Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: