Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34356

Allow the chooser dialogue to submit values for the radio button

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3, 2.6
    • Fix Version/s: 2.7
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      It's advisable to have your JS console open for these tests

      • Open a course page
      • Turn editing on
      • Open the activity chooser
      • Select an activity and choose the 'Add' button
        • Confirm that the correct modedit page was loaded
      Show
      It's advisable to have your JS console open for these tests Open a course page Turn editing on Open the activity chooser Select an activity and choose the 'Add' button Confirm that the correct modedit page was loaded
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull Master Branch:
      MDL-34356-master
    • Story Points:
      3
    • Sprint:
      FRONTEND Sprint 7

      Description

      This doesn't affect the activity chooser, but can affect others.

      When submitting the chooser dialogue, we disable a number of elements to prevent duplicate submissions. These include:

      • submit button
      • radio buttons

      Browsers don't submit the values of disabled elements though, and as a result, the chooser doesn't actually offer its selection.

      Since we ideally should disable the radio buttons, we need instead to create a new hidden field and set it's name and value to that of the radio button such that the value is sent in the request.

      This doesn't affect the Activity Chooser as that chooser already overrides this default functionality to set a value custom to the intended target (jumpurl).

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Petr Skoda
              Integrator:
              Damyon Wiese
              Tester:
              Adrian Greeve
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14