disabled ajax and 'quick feedback' in grader report causes grades to become 'overridden'

Better walk through:

1)Go to any course with a couple students and a couple grade items in the gradebook
2)Go in to the gradebook for that course
3)Go to "My preferences -> grader report"
4)Set "Show quick feedback" to "Yes" and "Enable ajax" to "No"
5)Go back to the grader report
6)'Update' the gradebook
7)Overridden status of the grade items might not reflect immediately. If they do not, go out of the gradebook and back in and grades not changed will now be overridden.

Seems to be the comparison on line 228 of 'grade/report/grader.php'

            } else if ($datatype === 'feedback') {
                if ($oldvalue->feedback === $postedvalue) {
                    continue;
                }
            }

If there is no existing feedback for the student the type of 'oldvalue->feedback' is NULL, the type of '$postedvalue' is string. So they never equal.

grade/report/grader/lib.php line 228

                if (($oldvalue->feedback === $postedvalue) or ($oldvalue->feedback === NULL and empty($postedvalue))) {
                    continue;
                }

This seems to correct the issue for me. First check if they are the same, if not but oldvalue is NULL and the new value is an empty string then move on.

Thanks for spotting that and providing a solution.

I have removed the old content from your description. It is still in the history of this issue if needed.

Yes, just had this issue reported by a staff member on our site too. Thanks, Patrick, for the patch - it has worked a charm.

I've made the patch in this ticket into pull branches.

We have been hit by the same thing!

When grade items are mentioned, do you mean grade items from activities or manual grade items? In our case manual grade items are not being overridden, just activities. Also, in our case, it doesn't matter whether or not ajax is enabled in the gradebook, this bug happens regardless.

When grade items are mentioned, do you mean grade items from activities or manual grade items? In our case manual grade items are not being overridden, just activities. Also, in our case, it doesn't matter whether or not ajax is enabled in the gradebook, this bug happens regardless.

I believe it was both, but we have my patch in place so I cannot test it at them moment.

Applying Eric's patch fixes this issue for us.

Just to point out to those wanting to apply this fix that the file to change is actually /grade/report/grader/lib.php.

Andrew, could you please take a look at this ticket.

Thanks!

Could this issue be affecting the 2.2 branch? I have a user who has identified these exact symptoms, but I have been unable to reproduce the issue.

Just wondering, the database default value for feedback is NULL. In grade/querylib.php on line 231, the feedback on the form is set to '' if the database value is NULL.
Could an alternate solution be to have the default feedback set to '' instead of NULL, then the original comparison on line 228 of /grade/report/grader/lib.php would work as intended.

Confirmed this is an issue within "Show quick feedback" regardless of AJAX settings in 2.3.1 and 2.3.2

We are still having this issue. I have noticed that if I have my gradebook set to show 6 students on the page, when I enter feedback in the gradebook, all assignments and grades are all overridden just on that one page. I don't know if that helps you in searching this or not. Just thought that was interesting. We sure would like to see it resolved. I have lots of data or will be will to test if you let me know.

Is there a patch or fix.... please direct me to correct place.

The fix is posted above.

Seeing this issue here too on 2.3.1+.

Sending all 'waiting for peer review' issues to integration before freeze, as agreed in Integrators Meeting 19/10/12. We are doing this to ensure any 'integratable issues' will not got missed before freeze..

Although this is already up for integration Im doing a last minute peer review.

[Y] Syntax
[Y] Output
[Y] Whitespace
[NA] Language
[NA] Databases
[Y] Testing
[Y] Security
[NA] Documentation
[Y] Git
[Y] Sanity check

Looks good. I'll add a few more steps to the testing instructions.

(thanks Andrew for reviewing, thats helpful)

Thanks Eric,

I've integrated this to 2.3 and master.

Tested this on 2.3 and master. It is working great.

Test passed.

Hurray!

You did it, congratulations! You have on Mojito credit to redeem after the release of Moodle 2.4