Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34367

Remove the call to set_popup_notification_allowed from message/lib.php

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.7, 2.3.1
    • Fix Version/s: 2.4
    • Component/s: Messages
    • Labels:
    • Database:
      Any
    • Testing Instructions:
      Hide

      You'll need 2 users in 2 separate browsers (firefox and chrome for example). The users will be the message sender and the message recipient.

      Log in as the recipient and check their messaging preferences. Make sure that personal messages are set to popup for both online and offline.

      Leave this page open.

      Log in as the sender and sender the recipient a message.

      As the recipient reload the messaging preferences page and check that you dont get a messaging popup.

      Go to My profile > messages and check that you dont get a messaging popup.

      Go to a course page and you should now get a messaging popup.

      If you mess up this somewhat delicate process somehow be aware that Moodle will only show popups every few minutes. If you need to start over go get a cup of coffee or do another test and come back to it.

      Show
      You'll need 2 users in 2 separate browsers (firefox and chrome for example). The users will be the message sender and the message recipient. Log in as the recipient and check their messaging preferences. Make sure that personal messages are set to popup for both online and offline. Leave this page open. Log in as the sender and sender the recipient a message. As the recipient reload the messaging preferences page and check that you dont get a messaging popup. Go to My profile > messages and check that you dont get a messaging popup. Go to a course page and you should now get a messaging popup. If you mess up this somewhat delicate process somehow be aware that Moodle will only show popups every few minutes. If you need to start over go get a cup of coffee or do another test and come back to it.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-34367_message_lib

      Description

      message/lib.php is calling $PAGE->set_popup_notification_allowed(false);

      lib files shouldnt be calling stuff. The individual files that are including the lib should be calling the function if they need it called.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    3/Dec/12