Moodle
  1. Moodle
  2. MDL-34379

Quiz reports show time taken for never submitted attempts as 'open'

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.1
    • Fix Version/s: 2.3.2
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide

      1. Create a quiz with 'When time expires' set to 'Attempts must be submitted before the time expires, or they are not counted', and a short time limit.

      2. Start a quiz attempt as a student, but don't finish it. Instead navigate back to the quiz view.php page.

      3. Wait for the time limit to run out, plus a bit, then reload the quiz view.php page. The attempt should now be shown as 'Never submitted'

      4. As teacher, go and look at the quiz reports. The Time taken for the overdue attempt should be not shown. (There will just be a - in the table cell.)

      Show
      1. Create a quiz with 'When time expires' set to 'Attempts must be submitted before the time expires, or they are not counted', and a short time limit. 2. Start a quiz attempt as a student, but don't finish it. Instead navigate back to the quiz view.php page. 3. Wait for the time limit to run out, plus a bit, then reload the quiz view.php page. The attempt should now be shown as 'Never submitted' 4. As teacher, go and look at the quiz reports. The Time taken for the overdue attempt should be not shown. (There will just be a - in the table cell.)
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      42771

      Description

      Quiz reports show time taken for never submitted attempts as 'open'

        Activity

        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Dan Poltawski added a comment -

        Thanks Tim, i've integrated that now.

        Show
        Dan Poltawski added a comment - Thanks Tim, i've integrated that now.
        Hide
        Rajesh Taneja added a comment -

        Works fine Tim,
        Time taken is showing "-".

        FYI:
        Changing "Attempts from" to "enrolled users who have not attempted the quiz" or "enrolled users who have or have not attempted the quiz" throw debugging message after clicking "Show report"

        Debug info: 
        Error code: codingerror
        Stack trace:
        line 846 of /mod/quiz/locallib.php: coding_exception thrown
        line 516 of /mod/quiz/attemptlib.php: call to quiz_attempt_state_name()
        line 155 of /mod/quiz/report/attemptsreport_table.php: call to quiz_attempt::state_name()
        line 703 of /lib/tablelib.php: call to quiz_attempts_report_table->col_state()
        line 1271 of /lib/tablelib.php: call to flexible_table->format_row()
        line 66 of /mod/quiz/report/overview/overview_table.php: call to table_sql->build_table()
        line 1383 of /lib/tablelib.php: call to quiz_overview_table->build_table()
        line 236 of /mod/quiz/report/overview/report.php: call to table_sql->out()
        line 100 of /mod/quiz/report.php: call to quiz_overview_report->display()
        

        Passing this test as patch doesn't seems to be causing this.

        Show
        Rajesh Taneja added a comment - Works fine Tim, Time taken is showing "-". FYI: Changing "Attempts from" to "enrolled users who have not attempted the quiz" or "enrolled users who have or have not attempted the quiz" throw debugging message after clicking "Show report" Debug info: Error code: codingerror Stack trace: line 846 of /mod/quiz/locallib.php: coding_exception thrown line 516 of /mod/quiz/attemptlib.php: call to quiz_attempt_state_name() line 155 of /mod/quiz/report/attemptsreport_table.php: call to quiz_attempt::state_name() line 703 of /lib/tablelib.php: call to quiz_attempts_report_table->col_state() line 1271 of /lib/tablelib.php: call to flexible_table->format_row() line 66 of /mod/quiz/report/overview/overview_table.php: call to table_sql->build_table() line 1383 of /lib/tablelib.php: call to quiz_overview_table->build_table() line 236 of /mod/quiz/report/overview/report.php: call to table_sql->out() line 100 of /mod/quiz/report.php: call to quiz_overview_report->display() Passing this test as patch doesn't seems to be causing this.
        Hide
        Aparup Banerjee added a comment -

        yay, it works!

        This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.

        Thank you all for taking the time to get us here.

        cheers!

        Show
        Aparup Banerjee added a comment - yay, it works! This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week. Thank you all for taking the time to get us here. cheers!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: