Details
-
Type:
Sub-task
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.4
-
Fix Version/s: 2.4
-
Component/s: Plagiarism
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_24_STABLE
-
Fixed Branches:MOODLE_24_STABLE
-
Pull from Repository:
-
Pull Master Branch:master_
MDL-34382_add_new_option_to_flag_modules_that_support_plagiarism_plugins
Description
now that multiple plugins support the use of the plagiarism API it would be nice to add a new option to the module_supports() functions so we can check this.
for example - mod/assign/lib.php function assign_supports() should have an item like this:
case FEATURE_PLAGIARISMAPI: return true;
(FEATURE_PLAGIARISMAPI should be defined in moodlelib.php like the other FEATURE defines)
For every module we have added support we should add this to the relevant module_supports function
Gliffy Diagrams
Attachments
Issue Links
- is blocked by
-
-
- Closed
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
Hi Dan,
I am not sure what is exactly to be done. Is this is what you meant? -
https://github.com/kanikagoyal/moodle/compare/master_MDL-34382_add_new_option_to_flag_modules_that_support_plagiarism_plugins
https://github.com/kanikagoyal/moodle/compare/master_add_option_in_assign_support_for_plagiarism_api
If this is right, then I will create patches for other modules too. Please let me know what changes are required.
Thanks,
Kanika
yeah - that's it but lets change this:
define('FEATURE_PLAGIARISMAPI', 'plagiarismapi');
to this:
define('FEATURE_PLAGIARISM', 'plagiarism');
Can you provide a single patch that adds the define to moodlelib and then to the modules that already support it that have been pushed (forum/assign/assignment) to this bug?
thanks!
Dan
Hi Dan,
Here is the patch - https://github.com/kanikagoyal/moodle/compare/master_MDL-34382_add_new_option_to_flag_modules_that_support_plagiarism_plugins
Let me know if it requires further modification.
Thanks,
Kanika
Hi Kanika/Dan,
This looks good, though you have added the capability to forum/workshop (which I don't think have plagarism capability yet?)
So i'd propose you only add it only to the core things which support it so you are able to land this change earlier than the other things landing.
cheers,
dan
Thanks Dan - Forum is supported already but the workshop patch hasn't gone in yet and I've linked that bug as a blocker for this - Workshop is ready for integration now so I'll submit this one when that has been integrated.
Hi Dan,
I think this can be integrated now?
Thanks,
Kanika
looks good - Kanika can you rebase this for the integrators just in case it causes conflicts? - thanks!
Update the link. 
Thanks,
Kanika
great! - thanks.
Thanks Kanika and Dan and Dan
That's been put thru to integration now. only in master.
Passing. Sorry for the delay!
For the good and the bad... this is now part of Moodle and people around the world will start using it immediately, what a responsibility!
Many thanks for your collaboration, yay!
Closing, ciao
Hi Kanika,
can you please implement this for the plugins that have patches already submitted as a separate patch on this bug including the new define in moodlelib.php and for the plugins that haven't been submitted yet can you please add this to the existing patches before we integrate them?
After doing this I'd like you to implement a setting with the plagiarism plugins that lets the site admin configure which modules they would like the plagiarism plugin to be enabled in - contact me via jabber to discuss further.
I think we should do this before you do much more work on the essay question stuff - thanks!