Moodle
  1. Moodle
  2. MDL-34396

TinyMCE HTML editor spell check fails on edit profile page due to https

    Details

    • Testing Instructions:
      Hide

      1. Ensure loginhttps is enabled
      2. Edit a user profile
      3. Enter text with spelling errors into the description and click spell check button
      4. VERIFY: that the errors are highlighted

      Show
      1. Ensure loginhttps is enabled 2. Edit a user profile 3. Enter text with spelling errors into the description and click spell check button 4. VERIFY: that the errors are highlighted
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w30_MDL-34396_m24_loginhttpsspell
    • Rank:
      42791

      Description

      The TinyMCE spell check fails on pages that require https such as the edit profile page. This because the rpc.php Ajax request does not use httpswwwroot which causes (some?) browsers to reject the request.

      To replicate this:
      1. Ensure loginhttps is enabled
      2. Edit a user profile
      3. Enter text with spelling errors into the description and click spell check button
      4. Error should be displayed and spelling errors will not be highlighted

      This was reported and fixed in 1.9 (MDL-8592) but has since appeared again in 2.x.

      Tested using FF 13 and Chrome 19.

      Patch to add httpswwwroot will be provided in comments shortly.

        Issue Links

          Activity

          Hide
          Luke Tucker added a comment -

          GitHub patch to switch spell check URL to use https:
          https://github.com/luke-tucker/moodle/compare/MDL-34396

          Show
          Luke Tucker added a comment - GitHub patch to switch spell check URL to use https: https://github.com/luke-tucker/moodle/compare/MDL-34396
          Hide
          Michael de Raadt added a comment -

          Thanks for spotting that and providing a patch.

          Show
          Michael de Raadt added a comment - Thanks for spotting that and providing a patch.
          Hide
          Petr Škoda added a comment -

          I have only slightly changed the commit message, thanks a lot for the patch and report.

          Show
          Petr Škoda added a comment - I have only slightly changed the commit message, thanks a lot for the patch and report.
          Hide
          Dan Poltawski added a comment -

          Thanks Luke and Petr,

          I've integrated this now.

          Show
          Dan Poltawski added a comment - Thanks Luke and Petr, I've integrated this now.
          Hide
          Dan Poltawski added a comment -

          Hmm.

          I'm struggling to test this because the html editor isn't loading with loginhttps on or off.

          Show
          Dan Poltawski added a comment - Hmm. I'm struggling to test this because the html editor isn't loading with loginhttps on or off.
          Hide
          Dan Poltawski added a comment -

          Hmm, well my problem was somehow relating to being an admin, but unrelated to this change. Which I tested and passes

          Show
          Dan Poltawski added a comment - Hmm, well my problem was somehow relating to being an admin, but unrelated to this change. Which I tested and passes
          Hide
          Aparup Banerjee added a comment -

          yay, it works!

          This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.

          Thank you all for taking the time to get us here.

          cheers!

          Show
          Aparup Banerjee added a comment - yay, it works! This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week. Thank you all for taking the time to get us here. cheers!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: