Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.1
    • Fix Version/s: 2.4
    • Component/s: Repositories
    • Labels:
    • Testing Instructions:
      Hide
      1. Set up your Alfresco repository
      2. Add an instance
      3. Go to your private files
      4. Make sure you can browse the Alfresco instance
      5. Make sure you can add files to your private files
      6. Make sure those files are still there and the same after you save your private files
      Show
      Set up your Alfresco repository Add an instance Go to your private files Make sure you can browse the Alfresco instance Make sure you can add files to your private files Make sure those files are still there and the same after you save your private files
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-34400-master

      Description

      While fixing MDL-29271, I encountered a bug in the API itself.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Frédéric Massart added a comment -

            This should probably not be backported to 2.x, but I think it could as I don't think the API changed that much since then. Although it is pretty hard to tell it from the diff...

            I have created a separate commit to include all of our local modifications to have it nicely integrated into Moodle.

            Show
            Frédéric Massart added a comment - This should probably not be backported to 2.x, but I think it could as I don't think the API changed that much since then. Although it is pretty hard to tell it from the diff... I have created a separate commit to include all of our local modifications to have it nicely integrated into Moodle.
            Hide
            Michael de Raadt added a comment -

            If this is a bug, it would be good to fix it for 2.2 and 2.3. That can happen after peer review.

            Show
            Michael de Raadt added a comment - If this is a bug, it would be good to fix it for 2.2 and 2.3. That can happen after peer review.
            Hide
            Frédéric Massart added a comment -

            The thing is that strangely this bug never occurred because MDL-29271 prevented it... in a way... by not allowing access to a certain resource.

            Show
            Frédéric Massart added a comment - The thing is that strangely this bug never occurred because MDL-29271 prevented it... in a way... by not allowing access to a certain resource.
            Hide
            Dan Poltawski added a comment -

            Hi Fred,

            Hmm, its a bit horrible that we need to apply these changes on top of the upstream stuff. Really what we are striving for is to avoid changing upstream at all.

            But, I suppose you've checked and we need to do those customisations, so if thats the case - great.

            If there is anything we can do to reduce the changes then it would be worth doing it.

            Show
            Dan Poltawski added a comment - Hi Fred, Hmm, its a bit horrible that we need to apply these changes on top of the upstream stuff. Really what we are striving for is to avoid changing upstream at all. But, I suppose you've checked and we need to do those customisations, so if thats the case - great. If there is anything we can do to reduce the changes then it would be worth doing it.
            Hide
            Frédéric Massart added a comment -

            I could not think of anything that could prevent those changes, but I'd be happy to if someone thinks of something. I am pushing this for integration.

            Show
            Frédéric Massart added a comment - I could not think of anything that could prevent those changes, but I'd be happy to if someone thinks of something. I am pushing this for integration.
            Hide
            Aparup Banerjee added a comment -

            just for the record: this API is at http://code.google.com/p/alfresco-php-sdk/ (as mentioned in the README.TXT in the patch)

            Show
            Aparup Banerjee added a comment - just for the record: this API is at http://code.google.com/p/alfresco-php-sdk/ (as mentioned in the README.TXT in the patch)
            Hide
            Aparup Banerjee added a comment -

            Thanks Fred, thats been integrated into master only. looking at MDL-29271 now.

            Tester: please explore while testing. (ie: multiple instances etc)

            Show
            Aparup Banerjee added a comment - Thanks Fred, thats been integrated into master only. looking at MDL-29271 now. Tester: please explore while testing. (ie: multiple instances etc)
            Hide
            Ankit Agarwal added a comment -

            works as expected.
            Thanks

            Show
            Ankit Agarwal added a comment - works as expected. Thanks
            Hide
            Aparup Banerjee added a comment -

            yay, it works!

            This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.

            Thank you all for taking the time to get us here.

            cheers!

            Show
            Aparup Banerjee added a comment - yay, it works! This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week. Thank you all for taking the time to get us here. cheers!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: