Details
-
Type:
Sub-task
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.3, 2.5
-
Fix Version/s: 2.5
-
Component/s: Libraries, Performance
-
Labels:
-
Testing Instructions:
Testing difficulty: Medium (test site upgrades and add-on installation to be done)
- Make sure that upgrading 2.3 -> patched 2.5 and 2.4 -> patched 2.5 works with no error related to this patch.
- Make sure that all tests from lib/tests/pluginlib_test.php pass.
- Browse the test site for a while and make sure everything seems to work as expected (JavaScript, file picker etc). Watch the MUC usage stats in the footer (you may need to define MDL_PERF and MDL_PERFTOFOOT constants in config.php). You should get hits in core_plugin* caches at most of the pages (at some administration pages, these caches are automatically purged so you can see the caches being set there with no hits).
- Try to disable/enable some activity modules, blocks, filters, repositories and/or portfolios. Again, no regression should be spotted.
- Try to install some add-on module or block. Again, no new error message or warning should be detected.
- So far so good? Hmm. That's suspicious... Anyway, let us consider it tested
Thanks!
Testing difficulty: Medium (test site upgrades and add-on installation to be done) Make sure that upgrading 2.3 -> patched 2.5 and 2.4 -> patched 2.5 works with no error related to this patch. Make sure that all tests from lib/tests/pluginlib_test.php pass. Browse the test site for a while and make sure everything seems to work as expected (JavaScript, file picker etc). Watch the MUC usage stats in the footer (you may need to define MDL_PERF and MDL_PERFTOFOOT constants in config.php). You should get hits in core_plugin* caches at most of the pages (at some administration pages, these caches are automatically purged so you can see the caches being set there with no hits). Try to disable/enable some activity modules, blocks, filters, repositories and/or portfolios. Again, no regression should be spotted. Try to install some add-on module or block. Again, no new error message or warning should be detected. So far so good? Hmm. That's suspicious... Anyway, let us consider it tested Thanks! -
Workaround:
-
Affected Branches:MOODLE_23_STABLE, MOODLE_25_STABLE
-
Fixed Branches:MOODLE_25_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-34401-muc-pluginlib -
Pull Master Diff URL:
Description
/lib/pluginlib has a number of static caches for things that don't change very much and may get called a lot. A good candidate for persistent caching between upgrades I think.
$this->pluginsinfo
$this->subpluginsinfo
$pluginversions
$blocksinfocache
$globalstatescache
$modulesinfocache
$repositories
$portfolios
Other candidates are core functions like get_plugin_list().
Attachments
Issue Links
- has a non-specific relationship to
-
MDL-41071 Class plugininfo_mod does not cache in the right cache definition
-
- Closed
-
