Moodle

M.util.get_string spawns needless YUI instances

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.2.4, 2.3.1
  • Fix Version/s: 2.2.5, 2.3.2
  • Component/s: AJAX and JavaScript
  • Labels:
    None

Description

Please see MDL-33448 for details.

Issue Links

discovered while testing

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-33448 Enrolment page very slow (freezes)

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dan Poltawski added a comment -

Thanks Sam, i've integrated this now.

Show
Dan Poltawski added a comment - Thanks Sam, i've integrated this now.
Hide
Permalink
Adrian Greeve added a comment -

I tested this in master to see how long it was taking for me to be able to access the Enrolled users page.
I noticed that the patch does increase the speed with which I can access the page. On my machine I was only delayed for about one second after the page had loaded.
Tested with:

  • Firefox
  • Chrome
  • IE
Show
Adrian Greeve added a comment - I tested this in master to see how long it was taking for me to be able to access the Enrolled users page. I noticed that the patch does increase the speed with which I can access the page. On my machine I was only delayed for about one second after the page had loaded. Tested with: Firefox Chrome IE
Hide
Permalink
Aparup Banerjee added a comment -

yay, it works!

This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.

Thank you all for taking the time to get us here.

cheers!

Show
Aparup Banerjee added a comment - yay, it works! This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week. Thank you all for taking the time to get us here. cheers!

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: