The use of fullname() is good. If we are not using fullname(), that's a problem.

The other possible problem is if the display format of the name is overridden by sending a second argument with true value to fullname(). If this is happening without checking for the capability moodle/site:viewfullnames, then this is a problem.

I had a quick scan through /message and I found...

$userfullname     = fullname($user, true);

There are some capability checks earlier in the file, but they are not for moodle/site:viewfullnames, so I'm not sure if this is sufficient.

All other calls to fullname() in that directory don't use a second argument.

Interestingly, that variable from edit.php is not used later in the file, so the statement could probably be removed.

I've removed the unnecessary fullname() call. Other than that I think we're using fullname correctly and are not outputting user names without using fullname().

Putting this up for peer review.

Looks good Andrew.
+1 for integration.
Thanks

Adding branches and putting up for integration.

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

(taking rid of the security flag for this)

Integrated (22, 23 & master), thanks!

works without errors Andrew, thanks

I'm so proud...of you, many thanks!

http://youtu.be/n64CdfDRnZY

Closing as fixed, ciao