[MDL-34406] Does messaging need to check a capbility before displaying user full name's? - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.2.4, 2.3, 2.4
Fix Version/s: 2.2.5, 2.3.2
Component/s: Messages
Labels:
- triaged

Database:

Any
Testing Instructions:

Hide

Just check that the messaging preferences screen loads without error.

Show
Just check that the messaging preferences screen loads without error.
Affected Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
Fixed Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE
Pull from Repository:
git://github.com/andyjdavis/moodle.git
Pull Master Branch:
~~MDL-34406~~_fullname
Pull Master Diff URL:
https://github.com/andyjdavis/moodle/compare/master...MDL-34406_fullname

Description

There are a number of places within /message where we call fullname(). Do we need to be doing a capability check? If so, what do we display instead?

Attachments

Issue Links

Testing discovered

MDL-28568 warning needed when sending message to non-contact but have 'do not receive messages from non-contacts' setting on.

Closed

Activity

People

Assignee:: Andrew Davis

Reporter:: Andrew Davis

Peer reviewer:: Ankit Agarwal

Integrator:: Eloy Lafuente (stronk7)

Tester:: Jason Fowler

Participants:: Andrew Davis, Ankit Agarwal, Eloy Lafuente (stronk7), Jason Fowler, Michael de Raadt

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 0 Start watching this issue

Dates

Created:: 20/Jul/12 12:57 AM

Updated:: 30/Sep/13 9:02 PM

Resolved:: 01/Sep/12 2:54 AM

Fix Release Date:: 10/Sep/12