Moodle

Afterburner Theme readability issues

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.3.1
  • Fix Version/s: 2.3.2
  • Component/s: Themes
  • Labels:
  • Testing Instructions:
    Hide
    1. Select Afterburner from Theme selector (NOT by URL)
    2. Go to any course page and with editing enabled open Topic 0.
    3. Using the HTML editor TEST that when adding an image using the filepicker that the input/select/button backgrounds are light enough to view any text displayed in them.
    Show
    Select Afterburner from Theme selector (NOT by URL) Go to any course page and with editing enabled open Topic 0. Using the HTML editor TEST that when adding an image using the filepicker that the input/select/button backgrounds are light enough to view any text displayed in them.
  • Affected Branches:
    MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_23_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    MDL-34412_master
  • Pull Master Diff URL:

Description

Upgraded to Moodle 2.3.1 and tested the new file-picker which is fantastic.

However, our site uses the excellent Afterburner theme which has a blue used by the file-picker and makes the black text illegible.

I edited the afterburner_styles.css files and replaced the offending blue colour (#34637f - as found by the eye dropper tool in Photoshop) with grey (#808080).

<!-- Extract from afterburner_styles.css

select, input, button {
background-color: #808080;
color: #fff;

This changed the global blue buttons to grey as expected and also changed the background colour in the file-picker dropdown box and buttons to grey.

There is still a readability issue that would be addressed if the text of those items could be changed to white.

Issue Links

will help resolve

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-34124 Theme Afterburner: can't read select menus in filemanager

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mary Evans added a comment - - edited

I am planning on working on this issue this weekend, so should be fixed in time for the next integration slot...

Show
Mary Evans added a comment - - edited I am planning on working on this issue this weekend, so should be fixed in time for the next integration slot...
Hide
Permalink
Sam Hemelryk added a comment -

Thanks Mary, this has been integrated now

Show
Sam Hemelryk added a comment - Thanks Mary, this has been integrated now
Hide
Permalink
Andrew Davis added a comment -

Seems fine. Passing.

Show
Andrew Davis added a comment - Seems fine. Passing.
Hide
Permalink
Aparup Banerjee added a comment -

yay, it works!

This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.

Thank you all for taking the time to get us here.

cheers!

Show
Aparup Banerjee added a comment - yay, it works! This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week. Thank you all for taking the time to get us here. cheers!

People

Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: