Moodle

Language string on chat module is incorrect

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.2.4, 2.3.1
  • Fix Version/s: 2.2.5, 2.3.2
  • Component/s: Chat
  • Labels:
  • Testing Instructions:
    Hide

    1/ Login to Moodle.
    2/ Create a test user
    3/ Enter a test course and enrol the test user as a student.
    4/ Create a chat activity in the course.
    5/ Ensure that the 'mod/chat:chat' capability is not allowed for the student role in the test course.
    6/ Login as the test user.
    7/ Verify that the message displays when trying to access the chat room (noting that the capability is disabled).

    Show
    1/ Login to Moodle. 2/ Create a test user 3/ Enter a test course and enrol the test user as a student. 4/ Create a chat activity in the course. 5/ Ensure that the 'mod/chat:chat' capability is not allowed for the student role in the test course. 6/ Login as the test user. 7/ Verify that the message displays when trying to access the chat room (noting that the capability is disabled).
  • Affected Branches:
    MOODLE_22_STABLE, MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_22_STABLE, MOODLE_23_STABLE
  • Pull from Repository:

Description

The language string displayed to a user when they are not allowed to enter a chat room is incorrect:
> mod/chat/lang/en/chat.php:$string['notallowenter'] = 'You are not allow to enter the chat room.';

It should be:
> mod/chat/lang/en/chat.php:$string['notallowenter'] = 'You are not allowed to enter the chat room.';

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jason Ilicic added a comment -

Patch provided at: https://github.com/jasonilicic/moodle/commit/1cb637e42a249eab84e0b825312dc8c85ab2a8d4

Show
Jason Ilicic added a comment - Patch provided at: https://github.com/jasonilicic/moodle/commit/1cb637e42a249eab84e0b825312dc8c85ab2a8d4
Hide
Permalink
Dan Poltawski added a comment -

Thanks Jason, looks good - i'm putting straight up for integration. Are you able to provide testing instructions?

TO INTEGRATOR: can be cherry-picked to 22 and master.

Show
Dan Poltawski added a comment - Thanks Jason, looks good - i'm putting straight up for integration. Are you able to provide testing instructions? TO INTEGRATOR: can be cherry-picked to 22 and master.
Hide
Permalink
Sam Hemelryk added a comment -

Thanks guys, I've integrated this now. Nice and easy!

Show
Sam Hemelryk added a comment - Thanks guys, I've integrated this now. Nice and easy!
Hide
Permalink
Jason Ilicic added a comment -

Sure.

1/ Login to Moodle.
2/ Create a test user
3/ Enter a test course and enrol the test user as a student.
4/ Create a chat activity in the course.
5/ Ensure that the 'mod/chat:chat' capability is not allowed for the student role in the test course.
6/ Login as the test user.
7/ Verify that the message displays when trying to access the chat room (noting that the capability is disabled).

Please let me know if you have any further issues with replicating/testing.

Show
Jason Ilicic added a comment - Sure. 1/ Login to Moodle. 2/ Create a test user 3/ Enter a test course and enrol the test user as a student. 4/ Create a chat activity in the course. 5/ Ensure that the 'mod/chat:chat' capability is not allowed for the student role in the test course. 6/ Login as the test user. 7/ Verify that the message displays when trying to access the chat room (noting that the capability is disabled). Please let me know if you have any further issues with replicating/testing.
Hide
Permalink
Frédéric Massart added a comment -

Test successful on 2.2, 2.3 and master. Thanks!

Show
Frédéric Massart added a comment - Test successful on 2.2, 2.3 and master. Thanks!
Hide
Permalink
Aparup Banerjee added a comment -

yay, it works!

This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.

Thank you all for taking the time to get us here.

cheers!

Show
Aparup Banerjee added a comment - yay, it works! This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week. Thank you all for taking the time to get us here. cheers!

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: