Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as the administrator
      2. Go to [Settings->Site administration->Reports->Logs]
      3. Select some logs (All participants, All days, All activities, All actions) and select 'Download in text format'. Click 'Get these logs'.
      4. Open the file in a text editor or spreadsheet application.

      [Test]
      Make sure that the data is in the appropriate format and that no errors have been generated.

      Show
      Log in as the administrator Go to [Settings->Site administration->Reports->Logs] Select some logs (All participants, All days, All activities, All actions) and select 'Download in text format'. Click 'Get these logs'. Open the file in a text editor or spreadsheet application. [Test] Make sure that the data is in the appropriate format and that no errors have been generated.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-34429-master
    • Rank:
      42832

      Description

      Log reports can be downloaded from admin>reports>logs

      Use the new class in lib/csvlib.class.php to export data into a csv, tsv or other delimited file.
      Examples can be found in:

      admin/user/usre_bulk_download.php
      grade/export/txt/grade_export_txt.php
      lib/tablelib.php
      mod/data/lib.php

        Issue Links

          Activity

          Hide
          Ankit Agarwal added a comment -

          Hi Adrian,
          Is the change to $filename intentional ?

          Thanks

          Show
          Ankit Agarwal added a comment - Hi Adrian, Is the change to $filename intentional ? Thanks
          Hide
          Ankit Agarwal added a comment - - edited

          Adrian explained that csvexporter class was adding the same date information to the filename. Hence the change was needed.

          All looks good to me.

          +1 for integration.
          Thanks

          Show
          Ankit Agarwal added a comment - - edited Adrian explained that csvexporter class was adding the same date information to the filename. Hence the change was needed. All looks good to me. +1 for integration. Thanks
          Hide
          Adrian Greeve added a comment -

          Thanks for the peer review Ankit and the discussion about titles in the csv file.

          Show
          Adrian Greeve added a comment - Thanks for the peer review Ankit and the discussion about titles in the csv file.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday.

          This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody.

          This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P

          Apologizes for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday. This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody. This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P Apologizes for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Aparup Banerjee added a comment -

          Thanks, thats been integrated into master only.

          Show
          Aparup Banerjee added a comment - Thanks, thats been integrated into master only.
          Hide
          Jason Fowler added a comment -

          this works fine - would be nice to be able to export as a CSV vs TSV though

          Show
          Jason Fowler added a comment - this works fine - would be nice to be able to export as a CSV vs TSV though
          Hide
          Eloy Lafuente (stronk7) added a comment -

          I'm so proud...of you, many thanks!

          http://youtu.be/n64CdfDRnZY

          Closing as fixed, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - I'm so proud...of you, many thanks! http://youtu.be/n64CdfDRnZY Closing as fixed, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: