Moodle
  1. Moodle
  2. MDL-34432

Assignment -teachers can no longer comment inline on online text

    Details

    • Testing Instructions:
      Hide

      Test 1 (comment inline functionality)

      1)Create a new assignment
      2)Ensure "online text" is set to Yes and "Feedback comments" are set to Yes and ensure "comment inline" is set to Yes
      3) Log in with student account and type some text
      4) Log back in with teacher account and verify that the student's text is included in your feedback box so you could if wished edit/highlight their words
      5) As a teacher grade a student who has not submitted anything and verify that the feedback box is empty

      Test 2 (Upgrading from 2.2 assignment to assignment (2.3))
      1)Create an assignment 2.2 of online text type
      2)Ensure "comment inline" is set to Yes
      3) Log in with student account and type some text
      4) Upgrade the assignment (2.2) to assignment 2.3
      5) Go to the new assignment settings page to double check if the comment inline setting is the same as the one in the 'old' assignment (set to Yes)
      6)Log back in with teacher account and verify that the student's text is included in your feedback box so you could if wished edit/highlight their words

      Test 3 (backup and restore assignment with comment inline set to Yes)

      1)Create a new assignment
      2)Ensure "online text" is set to Yes and "Feedback comments" are set to Yes and ensure "comment inline" is set to Yes
      3) Log in with student account and type some text
      4)Log back in with teacher account and verify that the student's text is included in your feedback box so you could if wished edit/highlight their words
      5) Backup the assignment and restore it
      6) Go to the restored assignment and see all the comment inline setting is the same as the original assignment

      Test 4 (assignment 2.3 with comment inline set to yes and onlinetext submission set to No)
      1)Create a new assignment
      2)Ensure "online text" is set to No and "Feedback comments" are set to Yes and ensure "comment inline" is set to Yes
      3)Log in with teacher account and verify that the feedback box functions as expected and it is not broken or anything as comment inline is ignored

      Show
      Test 1 (comment inline functionality) 1)Create a new assignment 2)Ensure "online text" is set to Yes and "Feedback comments" are set to Yes and ensure "comment inline" is set to Yes 3) Log in with student account and type some text 4) Log back in with teacher account and verify that the student's text is included in your feedback box so you could if wished edit/highlight their words 5) As a teacher grade a student who has not submitted anything and verify that the feedback box is empty Test 2 (Upgrading from 2.2 assignment to assignment (2.3)) 1)Create an assignment 2.2 of online text type 2)Ensure "comment inline" is set to Yes 3) Log in with student account and type some text 4) Upgrade the assignment (2.2) to assignment 2.3 5) Go to the new assignment settings page to double check if the comment inline setting is the same as the one in the 'old' assignment (set to Yes) 6)Log back in with teacher account and verify that the student's text is included in your feedback box so you could if wished edit/highlight their words Test 3 (backup and restore assignment with comment inline set to Yes) 1)Create a new assignment 2)Ensure "online text" is set to Yes and "Feedback comments" are set to Yes and ensure "comment inline" is set to Yes 3) Log in with student account and type some text 4)Log back in with teacher account and verify that the student's text is included in your feedback box so you could if wished edit/highlight their words 5) Backup the assignment and restore it 6) Go to the restored assignment and see all the comment inline setting is the same as the original assignment Test 4 (assignment 2.3 with comment inline set to yes and onlinetext submission set to No) 1)Create a new assignment 2)Ensure "online text" is set to No and "Feedback comments" are set to Yes and ensure "comment inline" is set to Yes 3)Log in with teacher account and verify that the feedback box functions as expected and it is not broken or anything as comment inline is ignored
    • Workaround:
      Hide

      Copy and paste the students' assignment text into your feedback box. Not brilliant as involves more effort and training for teachers.

      Show
      Copy and paste the students' assignment text into your feedback box. Not brilliant as involves more effort and training for teachers.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-34432-master
    • Story Points:
      8
    • Rank:
      53537
    • Sprint:
      FRONTEND Sprint 7

      Description

      In 1.9 there was an option "comment inline" which copied the students' online text assignment into the feedback box, allowing the teacher to comment directly onto their text- striking through, highlighting in red, etc, in addition to feedback comments. See forum thread here: http://moodle.org/mod/forum/discuss.php?d=207430
      There doesn't seem a way to do this with the online text version of the new assignment module (or if it is available, it is very difficult to find!) All references to "comment inline" in the tracker and QA testing seem to interpret the term differently but I notice in one test MDLQA-1872 Theresa Gibbison actually mentions she does not see the students's submission in the box; yet the test is passed. Many teachers like the 1.9 "comment inline" facility as it helps replicate marking in exercise books or on paper.

      How to reproduce:
      (Compare & Contrast)
      In 1.9
      1)Create an online text assignment and ensure "comment inline" is checked
      2)Log in with a student account and type in some text
      3)Log back in with teacher account and verify that the student's text is included in your feedback box so you could if wished edit/highlight their words
      In 2.3:
      1)Create a new assignment
      2)Ensure "online text" is set to Yes and "Feedback comments" are set to Yes
      3) Log in with student account and type some text
      4) Log back in as a teacher and verify the students' text does NOT appear in feedback box; therefore you can't scribble all over it like in exercise books

      1. out.mp4
        6.37 MB
        Damyon Wiese
      1. commentinline19.png
        39 kB

        Issue Links

          Activity

          Hide
          matt greenwolfe added a comment -

          Whoever works on this, please read the whole forum thread and change assignment to copy a teacher's previous feedback as well. http://moodle.org/mod/forum/discuss.php?d=207430

          Show
          matt greenwolfe added a comment - Whoever works on this, please read the whole forum thread and change assignment to copy a teacher's previous feedback as well. http://moodle.org/mod/forum/discuss.php?d=207430
          Hide
          Dave Madsen added a comment -

          This inline commenting function was one of the MOST USED functions of Moodle, and now it's not available. Copying and pasting the student's work into the Feedback box is not an answer...plus, if you go back, the previous comments appear to be lost.

          Show
          Dave Madsen added a comment - This inline commenting function was one of the MOST USED functions of Moodle, and now it's not available. Copying and pasting the student's work into the Feedback box is not an answer...plus, if you go back, the previous comments appear to be lost.
          Hide
          Damyon Wiese added a comment -

          Note that "previous comments appear to be lost" is a different Moodle bug which is now fixed.

          Show
          Damyon Wiese added a comment - Note that "previous comments appear to be lost" is a different Moodle bug which is now fixed.
          Hide
          Edwinna Lucyk added a comment -

          There are a number of teachers at my school who no longer want to use online text assignments due to the loss of the comment in line function. Even those that did not comment in line had the ability to type feedback in a box above the student's submission while the submission was visible below. Now that is not possible and grading an online text assignment is extremely cumbersome. At our school teachers used online text assignments to serve the purpose of reflective learning journals and the loss of this functionality in MOODLE 2.3 is troublesome.

          Show
          Edwinna Lucyk added a comment - There are a number of teachers at my school who no longer want to use online text assignments due to the loss of the comment in line function. Even those that did not comment in line had the ability to type feedback in a box above the student's submission while the submission was visible below. Now that is not possible and grading an online text assignment is extremely cumbersome. At our school teachers used online text assignments to serve the purpose of reflective learning journals and the loss of this functionality in MOODLE 2.3 is troublesome.
          Hide
          Martin Slavík added a comment -

          This is very important and also a most used feature of Moodle. Hard to explain to teachers, that inline comments are missing after upgrade. Please give it back soon.

          Show
          Martin Slavík added a comment - This is very important and also a most used feature of Moodle. Hard to explain to teachers, that inline comments are missing after upgrade. Please give it back soon.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          U P S T R E A M I Z E D !

          Many thanks, this is now available in all the repos (git & cvs).

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - U P S T R E A M I Z E D ! Many thanks, this is now available in all the repos (git & cvs). Closing, ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Doh,

          somehow this issue was closed incorrectly when processing all the integrated issues this week. (sort of most voted and current in integration filters mix). Apologies for the confusion, reseting to previous status!

          Ciao, Eloy

          Show
          Eloy Lafuente (stronk7) added a comment - Doh, somehow this issue was closed incorrectly when processing all the integrated issues this week. (sort of most voted and current in integration filters mix). Apologies for the confusion, reseting to previous status! Ciao, Eloy
          Hide
          Damyon Wiese added a comment -

          Note: I have Raymond working on this feature and he should have a patch ready this week.

          Regards, Damyon

          Show
          Damyon Wiese added a comment - Note: I have Raymond working on this feature and he should have a patch ready this week. Regards, Damyon
          Hide
          Chien Wen-Chang(簡文章) added a comment -

          I tested MDL-34432_M23. An error occured.

          PHP Fatal error: Call to private method assign::get_user_submission() from context 'assign_feedback_comments' in E:\moodleweb\mod\assign\feedback\comments\locallib.php on line 149

          Show
          Chien Wen-Chang(簡文章) added a comment - I tested MDL-34432 _M23. An error occured. PHP Fatal error: Call to private method assign::get_user_submission() from context 'assign_feedback_comments' in E:\moodleweb\mod\assign\feedback\comments\locallib.php on line 149
          Hide
          Raymond Antonio added a comment -

          Hi Chien,
          I Removed patch for 2.3 altogether as MDL-34432 needs these MDL-35475 and some methods in assign API added in this MDL-31276 to get it working in 2.3

          Show
          Raymond Antonio added a comment - Hi Chien, I Removed patch for 2.3 altogether as MDL-34432 needs these MDL-35475 and some methods in assign API added in this MDL-31276 to get it working in 2.3
          Hide
          Damyon Wiese added a comment -

          Thanks Raymond - I have added some comments in github and we need a few changes before this code is accepted.

          Show
          Damyon Wiese added a comment - Thanks Raymond - I have added some comments in github and we need a few changes before this code is accepted.
          Hide
          Raymond Antonio added a comment -

          Hi Damyon,

          Thank you very much for your feedbacks. I just updated my patch to accommodate all of your feedbacks. Cheers

          Show
          Raymond Antonio added a comment - Hi Damyon, Thank you very much for your feedbacks. I just updated my patch to accommodate all of your feedbacks. Cheers
          Hide
          Mary Cooch added a comment -

          Where are we up to with this? It's been a very popular request and I note while testing 2.4 that I don't seem to be able to do it.

          Show
          Mary Cooch added a comment - Where are we up to with this? It's been a very popular request and I note while testing 2.4 that I don't seem to be able to do it.
          Hide
          Martin Slavík added a comment -

          Please, take care about Moodle users, test it first thoroughly and communicate about changes, we do not want foolish development, this + broken grading in 2.3 version (http://tracker.moodle.org/browse/MDL-36509) make teachers completely mad. Although is new Moodle technically better than old one, in terms of usability it is real disaster. I am afraid that the Moodle repute could be very easily lost with this type of problems...

          Show
          Martin Slavík added a comment - Please, take care about Moodle users, test it first thoroughly and communicate about changes, we do not want foolish development, this + broken grading in 2.3 version ( http://tracker.moodle.org/browse/MDL-36509 ) make teachers completely mad. Although is new Moodle technically better than old one, in terms of usability it is real disaster. I am afraid that the Moodle repute could be very easily lost with this type of problems...
          Hide
          Stephen Overall added a comment -

          Sure hope this restoration of lost functionality can land in both the 2.4 release and 2.3 update. (Doing the manual copy-and-paste-from-a-separate-browser-tab workaround with my many students is getting old.) Thanks to all who've worked on it.

          Show
          Stephen Overall added a comment - Sure hope this restoration of lost functionality can land in both the 2.4 release and 2.3 update. (Doing the manual copy-and-paste-from-a-separate-browser-tab workaround with my many students is getting old.) Thanks to all who've worked on it.
          Hide
          Damyon Wiese added a comment -

          Added a patch to clean up some long lines and add AMOS commands to the commit comments.

          Show
          Damyon Wiese added a comment - Added a patch to clean up some long lines and add AMOS commands to the commit comments.
          Hide
          Damyon Wiese added a comment -

          This patch depends on an API change introduced in the linked patch.

          Show
          Damyon Wiese added a comment - This patch depends on an API change introduced in the linked patch.
          Hide
          Damyon Wiese added a comment -

          I also bumped the version of the assignfeedback_comments plugin as it has new settings and lang strings.

          Show
          Damyon Wiese added a comment - I also bumped the version of the assignfeedback_comments plugin as it has new settings and lang strings.
          Hide
          Raymond Antonio added a comment - - edited

          Hi Damyon,
          Thank you for this.I've just tested it thoroughly and found a bug that only occurs when a student hasn't made any online text submission yet and when the teacher views the student's grading page, the feedback editor is broken (format) and the page gives this warning if Notice: Trying to get property of non-object in mod/assign/feedback/comments/locallib.php on line 224 Notice: Trying to get property of non-object in mod/assign/feedback/comments/locallib.php on line 229 Notice: Trying to get property of non-object in mod/assign/feedback/comments/locallib.php on line 232 ?

          I have a patch to fix this and I will put this up soon, just want to confirm if anyone has encountered the same bug ?

          Cheers

          Show
          Raymond Antonio added a comment - - edited Hi Damyon, Thank you for this.I've just tested it thoroughly and found a bug that only occurs when a student hasn't made any online text submission yet and when the teacher views the student's grading page, the feedback editor is broken (format) and the page gives this warning if Notice: Trying to get property of non-object in mod/assign/feedback/comments/locallib.php on line 224 Notice: Trying to get property of non-object in mod/assign/feedback/comments/locallib.php on line 229 Notice: Trying to get property of non-object in mod/assign/feedback/comments/locallib.php on line 232 ? I have a patch to fix this and I will put this up soon, just want to confirm if anyone has encountered the same bug ? Cheers
          Hide
          Damyon Wiese added a comment -

          Testing Raymonds comments.

          Show
          Damyon Wiese added a comment - Testing Raymonds comments.
          Hide
          Damyon Wiese added a comment -

          Thanks Raymond - I get the same error. Let me know when you have posted a fix and I'll take another look.

          Show
          Damyon Wiese added a comment - Thanks Raymond - I get the same error. Let me know when you have posted a fix and I'll take another look.
          Hide
          Raymond Antonio added a comment -

          Thanks for a prompt response Damyon. I'llbe putting up a patch for your review in mins

          Show
          Raymond Antonio added a comment - Thanks for a prompt response Damyon. I'llbe putting up a patch for your review in mins
          Hide
          Raymond Antonio added a comment -

          Hi Damyon,
          Here is my patch. looking forward to your feedback. Thanks
          https://github.com/raymondAntonio/moodle/commit/11ce103c091c72595d470a04367286946a23202c

          Show
          Raymond Antonio added a comment - Hi Damyon, Here is my patch. looking forward to your feedback. Thanks https://github.com/raymondAntonio/moodle/commit/11ce103c091c72595d470a04367286946a23202c
          Hide
          Damyon Wiese added a comment -

          Hi Raymond -

          Can you please squash all these commits into a single one to clean up the history?

          Also - looking at your patch - You could move

                              $data->assignfeedbackcomments_editor['text'] = '';
                              $data->assignfeedbackcomments_editor['format'] = editors_get_preferred_format();
          

          Outside the if instead of having an if, else.

          Also - the white spacing for your if statement is wrong.

          Thanks, Damyon

          Show
          Damyon Wiese added a comment - Hi Raymond - Can you please squash all these commits into a single one to clean up the history? Also - looking at your patch - You could move $data->assignfeedbackcomments_editor['text'] = ''; $data->assignfeedbackcomments_editor['format'] = editors_get_preferred_format(); Outside the if instead of having an if, else. Also - the white spacing for your if statement is wrong. Thanks, Damyon
          Hide
          Raymond Antonio added a comment -

          Hi Damyon,

          Thanks For your quick feedback. Yes, I will do it soon . Thanks

          Show
          Raymond Antonio added a comment - Hi Damyon, Thanks For your quick feedback. Yes, I will do it soon . Thanks
          Show
          Raymond Antonio added a comment - - edited Hi Damyon, As you suggested, 1. Fixed and squashed MDL-34432 -23: https://github.com/raymondAntonio/moodle/commit/52be1e6597c6a4acbe8cdadbe61d3dd1e6753743 2. Fixed and squashed MDL-34432 -master: https://github.com/raymondAntonio/moodle/commit/d57f59b9b64eca76125781c8a584388c3e5f6c74 Cheers
          Hide
          Jeremy Schambaugh added a comment -

          So I added the changes from Raymond to my 2.3.1+ installation, turned on option for Comment Inline, yet when I go to grade the Feedback Comments area with the text box is no where to be found. What am I missing?

          Show
          Jeremy Schambaugh added a comment - So I added the changes from Raymond to my 2.3.1+ installation, turned on option for Comment Inline, yet when I go to grade the Feedback Comments area with the text box is no where to be found. What am I missing?
          Hide
          Kris Stokking added a comment -

          Damyon - could you please provide an update on this ticket? Do you need any assistance? Thanks!

          Show
          Kris Stokking added a comment - Damyon - could you please provide an update on this ticket? Do you need any assistance? Thanks!
          Hide
          Damyon Wiese added a comment -

          There were still issues in the last patch that needed fixing - I'll take over this ticket and fix anything outstanding.

          Show
          Damyon Wiese added a comment - There were still issues in the last patch that needed fixing - I'll take over this ticket and fix anything outstanding.
          Hide
          Mary Cooch added a comment -

          Thanks Damyon; this will be so welcome

          Show
          Mary Cooch added a comment - Thanks Damyon; this will be so welcome
          Hide
          Tayla Craig added a comment -

          Looking forward to the updates! I presented at a conference this week, and this was a commonly asked question. This feature is greatly missed! Thanks for your work!

          Show
          Tayla Craig added a comment - Looking forward to the updates! I presented at a conference this week, and this was a commonly asked question. This feature is greatly missed! Thanks for your work!
          Hide
          Jeremy Schambaugh added a comment -

          I cannot get this to work at all. The Feedback Comments area with the text box is completely missing after adding all these changes.

          Show
          Jeremy Schambaugh added a comment - I cannot get this to work at all. The Feedback Comments area with the text box is completely missing after adding all these changes.
          Hide
          Chris Follin added a comment -

          Echoing Mary and Tayla, as well as several people earlier in the discussion, we're also eager for this feature to return. Our clients miss it. A big thank you to everyone working on this. We hope to see it land soon.

          Show
          Chris Follin added a comment - Echoing Mary and Tayla, as well as several people earlier in the discussion, we're also eager for this feature to return. Our clients miss it. A big thank you to everyone working on this. We hope to see it land soon.
          Hide
          Damyon Wiese added a comment -

          The outstanding issues are related to feedback comments not supporting file attachments (because the gradebook does not support file attachments). Gradebook does not support file attachments because it is incompatible with quick feedback (which already has issues with html).

          So - solving MDL-19135 will allow be to add attachments to feedback comments and then we can sensibly copy the submission files to the feedback file area and that will solve this issue properly.

          (The current patch rewrites the URLs to point to the files in the submission file area - but the permissions for people viewing the gradebook can be different to the permissions for people viewing the feedback can be different to the permissions for people viewing the submission (ie - each area needs it's own copy of the files).

          Show
          Damyon Wiese added a comment - The outstanding issues are related to feedback comments not supporting file attachments (because the gradebook does not support file attachments). Gradebook does not support file attachments because it is incompatible with quick feedback (which already has issues with html). So - solving MDL-19135 will allow be to add attachments to feedback comments and then we can sensibly copy the submission files to the feedback file area and that will solve this issue properly. (The current patch rewrites the URLs to point to the files in the submission file area - but the permissions for people viewing the gradebook can be different to the permissions for people viewing the feedback can be different to the permissions for people viewing the submission (ie - each area needs it's own copy of the files).
          Hide
          Damyon Wiese added a comment -

          I will play with MDL-19135

          Show
          Damyon Wiese added a comment - I will play with MDL-19135
          Hide
          Jason Hardin added a comment -

          You may want to update MDL-19135 to actually be about Moodle 2 and not Moodle 1.9.

          Show
          Jason Hardin added a comment - You may want to update MDL-19135 to actually be about Moodle 2 and not Moodle 1.9.
          Hide
          Mary Cooch added a comment -

          I just linked and updated MDL-19135 for future reference. With some 43 votes and 36 watchers, it would be great if this can be fixed sometime soon.

          Show
          Mary Cooch added a comment - I just linked and updated MDL-19135 for future reference. With some 43 votes and 36 watchers, it would be great if this can be fixed sometime soon.
          Hide
          Tayla Craig added a comment - - edited

          I agree with Mary, this is still a greatly missed feature. It comes up multiple times in every training I conduct. It is a feature potential Moodlers looking for in a LMS as well. I was sad to see that it's not been added back to 2.5.

          Show
          Tayla Craig added a comment - - edited I agree with Mary, this is still a greatly missed feature. It comes up multiple times in every training I conduct. It is a feature potential Moodlers looking for in a LMS as well. I was sad to see that it's not been added back to 2.5.
          Hide
          Joe Rowe added a comment -

          I am still using version 1.9 because of this feature. We use google docs for multi-player editing. The main complaint I get from students is trouble finding feedback on items I've graded. Even in version 1.9 I put my comments in with a yellow background. It looks like highlighting. It's shocking that this bug has existed so long.

          Show
          Joe Rowe added a comment - I am still using version 1.9 because of this feature. We use google docs for multi-player editing. The main complaint I get from students is trouble finding feedback on items I've graded. Even in version 1.9 I put my comments in with a yellow background. It looks like highlighting. It's shocking that this bug has existed so long.
          Hide
          Stephen Overall added a comment -

          Just a note that resolving this issue MDL-34432 seems dependent upon resolving MDL-19135 first as Daymon Wiese explains clearly above. Currently no one is assigned to work on MDL-19135 (which has only two votes btw – more votes for MDL-19135 might help).

          I wish I could help with the actual work, but I'm not a PHP developer, only a Moodle-using teacher. I send any thanks to all Moodle devs!

          Show
          Stephen Overall added a comment - Just a note that resolving this issue MDL-34432 seems dependent upon resolving MDL-19135 first as Daymon Wiese explains clearly above. Currently no one is assigned to work on MDL-19135 (which has only two votes btw – more votes for MDL-19135 might help). I wish I could help with the actual work, but I'm not a PHP developer, only a Moodle-using teacher. I send any thanks to all Moodle devs!
          Hide
          Michael de Raadt added a comment -

          Assigning to the FRONTEND backlog.

          Show
          Michael de Raadt added a comment - Assigning to the FRONTEND backlog.
          Hide
          Mary Cooch added a comment -

          I was asked about this loss of functionality at the Montana Moot last week- just wondering when people might get a chance to have a look at it?

          Show
          Mary Cooch added a comment - I was asked about this loss of functionality at the Montana Moot last week- just wondering when people might get a chance to have a look at it?
          Hide
          Chien Wen-Chang(簡文章) added a comment - - edited

          I modified and merged some codes for comment inline on online text.
          For uploading image and NanoGong voice recording function on online
          text submission and feedback, I added some codes.
          These codes were used in http://moodle.ncnu.edu.tw since November 25, 2012.
          http://moodle.ncnu.edu.tw/mod/forum/discuss.php?d=151499
          http://moodle.ncnu.edu.tw/mod/forum/discuss.php?d=151501

          Moodle 2.5 Diff URL: https://github.com/wcchien/moodle25-mod_assign/commit/58fa8801322d9d14f9abcc5a344723f3b59c2d33

          Moodle 2.3 Diff URL: https://github.com/wcchien/moodle23-mod_assign/commit/a98adf0341db56d27f9c42836c12f88577c96e4c

          Show
          Chien Wen-Chang(簡文章) added a comment - - edited I modified and merged some codes for comment inline on online text. For uploading image and NanoGong voice recording function on online text submission and feedback, I added some codes. These codes were used in http://moodle.ncnu.edu.tw since November 25, 2012. http://moodle.ncnu.edu.tw/mod/forum/discuss.php?d=151499 http://moodle.ncnu.edu.tw/mod/forum/discuss.php?d=151501 Moodle 2.5 Diff URL: https://github.com/wcchien/moodle25-mod_assign/commit/58fa8801322d9d14f9abcc5a344723f3b59c2d33 Moodle 2.3 Diff URL: https://github.com/wcchien/moodle23-mod_assign/commit/a98adf0341db56d27f9c42836c12f88577c96e4c
          Hide
          Mary Cooch added a comment -

          I do realise that in 2.6, teachers are able to annotate and comment directly on submitted pdf files. However, this is quite a different situation and sometimes it is not appropriate for students to create, convert to and upload pdf files and it is much more suitable that they type their responses directly into Moodle. Teachers of students beginning language learning for example or teachers of younger children only require shorter text responses and online text submissions have always fitted the bill. It would be good to have this functionality restored.

          Show
          Mary Cooch added a comment - I do realise that in 2.6, teachers are able to annotate and comment directly on submitted pdf files. However, this is quite a different situation and sometimes it is not appropriate for students to create, convert to and upload pdf files and it is much more suitable that they type their responses directly into Moodle. Teachers of students beginning language learning for example or teachers of younger children only require shorter text responses and online text submissions have always fitted the bill. It would be good to have this functionality restored.
          Hide
          Tayla Craig added a comment -

          As usual, I agree with Mary. This is a greatly missed feature, and we'd like to just have the option to use it in the future.

          Show
          Tayla Craig added a comment - As usual, I agree with Mary. This is a greatly missed feature, and we'd like to just have the option to use it in the future.
          Hide
          Nadav Kavalerchik added a comment -

          I agree with Mary too. (Also getting complaints about this. regularly. even today)

          Show
          Nadav Kavalerchik added a comment - I agree with Mary too. (Also getting complaints about this. regularly. even today)
          Hide
          Peter Nejsum added a comment -

          I can only agree with you guys - this is a greatly missed feature. I feel however that it is being ignored (with currently 59 voted and 46 watchers, it is difficult for me to understand how and why). I do understand that resolving this issue may be dependent upon MDL-19135, but it would be great with an 'official' statement regarding progress and plans with this issue. I feel we are all left in the dark here :-/

          Show
          Peter Nejsum added a comment - I can only agree with you guys - this is a greatly missed feature. I feel however that it is being ignored (with currently 59 voted and 46 watchers, it is difficult for me to understand how and why). I do understand that resolving this issue may be dependent upon MDL-19135 , but it would be great with an 'official' statement regarding progress and plans with this issue. I feel we are all left in the dark here :-/
          Hide
          Martin Dougiamas added a comment -

          Would it be good if, instead, we made the commenting for online text work exactly like the pdf commenting? So basically we would "freeze" the online text first into a pdf and then go from there. Result would be a pdf too.

          Show
          Martin Dougiamas added a comment - Would it be good if, instead, we made the commenting for online text work exactly like the pdf commenting? So basically we would "freeze" the online text first into a pdf and then go from there. Result would be a pdf too.
          Hide
          Mary Cooch added a comment -

          I think that could work, potentially. The main thing as I see it is that (1)students can type their responses directly into Moodle's text editor and (2)that the teacher can easily annotate them. If (1) students can still do that, and then Moodle handles the difficult job of converting to pdf, then (2) is quite straightforward for teachers to do just as with regular pdf assignment. I would imagine the converted online text would have to be able to include any embedded images, for example, rather than just plain text.

          Show
          Mary Cooch added a comment - I think that could work, potentially. The main thing as I see it is that (1)students can type their responses directly into Moodle's text editor and (2)that the teacher can easily annotate them. If (1) students can still do that, and then Moodle handles the difficult job of converting to pdf, then (2) is quite straightforward for teachers to do just as with regular pdf assignment. I would imagine the converted online text would have to be able to include any embedded images, for example, rather than just plain text.
          Hide
          Stéphane Lavoie added a comment -

          It's not exactly what is requested from my ESL teachers. Freezing the online text into a pdf implies that students will have to cut and paste text from the annotated PDF in order to continue or finish their assignment.

          But, as we often say in french : «Nul n'est tenu à l'impossible». If it is easier for you to go through PDF annotation, let's go this way! It will put a certain uniformity into commenting.

          Show
          Stéphane Lavoie added a comment - It's not exactly what is requested from my ESL teachers. Freezing the online text into a pdf implies that students will have to cut and paste text from the annotated PDF in order to continue or finish their assignment. But, as we often say in french : «Nul n'est tenu à l'impossible». If it is easier for you to go through PDF annotation, let's go this way! It will put a certain uniformity into commenting.
          Hide
          Damyon Wiese added a comment -

          Well - the way forward with this issue is to allow copying the text from the student submission into the feedback text - but we will have to strip Moodle files from the text. We can also do the PDF thing but that is more heavy weight and the PDF may not be a 100% accurate representation of the student text (e.g. embedded videos, images need downloading and embedding, layout, fonts, etc).

          What we cannot do is allow files in the feedback area, or "hotlink" the images from the student submission.

          I will look at the PDF thing in a separate issue and just do the copy text/strip images in this one.

          Show
          Damyon Wiese added a comment - Well - the way forward with this issue is to allow copying the text from the student submission into the feedback text - but we will have to strip Moodle files from the text. We can also do the PDF thing but that is more heavy weight and the PDF may not be a 100% accurate representation of the student text (e.g. embedded videos, images need downloading and embedding, layout, fonts, etc). What we cannot do is allow files in the feedback area, or "hotlink" the images from the student submission. I will look at the PDF thing in a separate issue and just do the copy text/strip images in this one.
          Hide
          Damyon Wiese added a comment -

          Link to PDF issue added.

          Show
          Damyon Wiese added a comment - Link to PDF issue added.
          Hide
          Damyon Wiese added a comment -

          This new patch is ready for review. There are unit tests and behat tests. This is a UI change and an improvement - MASTER ONLY!

          Currently the unit tests will show a debugging notice. This is caused by MDL-43295 so I have set that as a blocker.

          Show
          Damyon Wiese added a comment - This new patch is ready for review. There are unit tests and behat tests. This is a UI change and an improvement - MASTER ONLY! Currently the unit tests will show a debugging notice. This is caused by MDL-43295 so I have set that as a blocker.
          Hide
          Dan Poltawski added a comment -

          Hi Damyon,

          All the code looks good, some small things..

          1. I think the strip_moodle_content() function could benefit from explicit unit testing (mostly thinking about the 'url' detection).
          2. The @wip tag is still there
          3. Needs rebasing.
          4. I think it would be good to have Mary or someone to try this out before submitting. So that we can be sure that this slightly different method to the old assignment plugin enables the same use cases as before.
          Show
          Dan Poltawski added a comment - Hi Damyon, All the code looks good, some small things.. I think the strip_moodle_content() function could benefit from explicit unit testing (mostly thinking about the 'url' detection). The @wip tag is still there Needs rebasing. I think it would be good to have Mary or someone to try this out before submitting. So that we can be sure that this slightly different method to the old assignment plugin enables the same use cases as before.
          Hide
          Damyon Wiese added a comment -

          Thanks Dan.

          1. It is covered by test_feedback_comment_commentinline(). I added some more nasties to that test.

          2. Oops - removed.

          3. Done.

          4. Will add a screen recording of this (saves pulling the patch) and will add Mary as a watcher.

          Show
          Damyon Wiese added a comment - Thanks Dan. 1. It is covered by test_feedback_comment_commentinline(). I added some more nasties to that test. 2. Oops - removed. 3. Done. 4. Will add a screen recording of this (saves pulling the patch) and will add Mary as a watcher.
          Hide
          Mary Cooch added a comment -

          I am watching already since I reported it

          Show
          Mary Cooch added a comment - I am watching already since I reported it
          Hide
          Damyon Wiese added a comment - - edited

          Ah good - thanks - can you check the video (out.mp4) (or pull the patch and have a play)?

          Show
          Damyon Wiese added a comment - - edited Ah good - thanks - can you check the video (out.mp4) (or pull the patch and have a play)?
          Hide
          Mary Cooch added a comment -

          Checked the video and pulled the patch and tested it out - it does just what I would wish it to do. I don't think it matters about images not coming through since the teacher could see those in the original version anyway. Thanks - this looks very useful.

          Show
          Mary Cooch added a comment - Checked the video and pulled the patch and tested it out - it does just what I would wish it to do. I don't think it matters about images not coming through since the teacher could see those in the original version anyway. Thanks - this looks very useful.
          Hide
          Damyon Wiese added a comment -

          OK - so seems all good then. Dan can you check that you are happy with the extended unit test for 1 ?

          Show
          Damyon Wiese added a comment - OK - so seems all good then. Dan can you check that you are happy with the extended unit test for 1 ?
          Hide
          Damyon Wiese added a comment -

          Pushing for integration.

          Show
          Damyon Wiese added a comment - Pushing for integration.
          Hide
          Sam Hemelryk added a comment -

          Hi Damyon,

          I've noticed this is causing a behat error. Would you mind looking at that?

          vendor/bin/behat --config /var/www-data/integration_dehat/behat/behat.yml --name 'Submit a text online and edit the submission'
          ------------------
          01. The "(//html/.//a[./@href][(((./@id = 'Hide Submission comments' or contains(normalize-space(string(.)), 'Hide Submission comments')) or contains(./@title, 'Hide Submission comments') or contains(./@rel, 'Hide Submission comments')) or .//img[contains(./@alt, 'Hide Submission comments')])] | .//*[./@role = 'link'][((./@id = 'Hide Submission comments' or contains(./@value, 'Hide Submission comments')) or contains(./@title, 'Hide Submission comments') or contains(normalize-space(string(.)), 'Hide Submission comments'))])[1]" xpath node is not visible and it should be visible
          In step `Then I click on "Hide Submission comments" "link"'. # behat_general::i_click_on()
          From scenario `Submit a text online and edit the submission'. # /var/www/integration/mod/assign/tests/behat/comment_inline.feature:8
          Of feature `In an assignment, teachers can edit a students submission inline'.

          Show
          Sam Hemelryk added a comment - Hi Damyon, I've noticed this is causing a behat error. Would you mind looking at that? vendor/bin/behat --config /var/www-data/integration_dehat/behat/behat.yml --name 'Submit a text online and edit the submission' ------------------ 01. The "(//html/.//a [./@href] [(((./@id = 'Hide Submission comments' or contains(normalize-space(string(.)), 'Hide Submission comments')) or contains(./@title, 'Hide Submission comments') or contains(./@rel, 'Hide Submission comments')) or .//img [contains(./@alt, 'Hide Submission comments')] )] | .//* [./@role = 'link'] [((./@id = 'Hide Submission comments' or contains(./@value, 'Hide Submission comments')) or contains(./@title, 'Hide Submission comments') or contains(normalize-space(string(.)), 'Hide Submission comments'))] ) [1] " xpath node is not visible and it should be visible In step `Then I click on "Hide Submission comments" "link"'. # behat_general::i_click_on() From scenario `Submit a text online and edit the submission'. # /var/www/integration/mod/assign/tests/behat/comment_inline.feature:8 Of feature `In an assignment, teachers can edit a students submission inline'.
          Hide
          Damyon Wiese added a comment -

          Looking now.

          Show
          Damyon Wiese added a comment - Looking now.
          Hide
          Damyon Wiese added a comment - - edited

          Fix added - I changed the test to log out and back in as the student to see their feedback as getting it from the grading table was just hard. (I amended the previous commit)

          Show
          Damyon Wiese added a comment - - edited Fix added - I changed the test to log out and back in as the student to see their feedback as getting it from the grading table was just hard. (I amended the previous commit)
          Hide
          Sam Hemelryk added a comment -

          Thanks Damyon - looks spot on now and has been integrated.

          Show
          Sam Hemelryk added a comment - Thanks Damyon - looks spot on now and has been integrated.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Sorry but his has been detected to be the responsible for master's phpunit tests failing with some incorrect format_text() use:

          Please fix, TIA! Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Sorry but his has been detected to be the responsible for master's phpunit tests failing with some incorrect format_text() use: http://integration.moodle.org/view/master/job/20.%20Run%20phpunit%20UnitTests%20(master)/2176/console Please fix, TIA! Ciao
          Hide
          Frédéric Massart added a comment -

          Sorry, but I have to fail this test for 2 minor things:

          1. Unrelated, but I spotted this when submitting an online text.
            Notice: Use of undefined constant FILE_INTERNAL - assumed 'FILE_INTERNAL' in /Users/fmc/code/php/repositories/im/moodle/mod/assignment/type/online/assignment.class.php on line 46
            
            Notice: Use of undefined constant FILE_EXTERNAL - assumed 'FILE_EXTERNAL' in /Users/fmc/code/php/repositories/im/moodle/mod/assignment/type/online/assignment.class.php on line 47
            
          2. After upgrading an 2.2 assignment to the new one, the setting "Comment inline" still appears as "No", though it is enabled as the teacher gets its feedback populated with the student's submission.
          Show
          Frédéric Massart added a comment - Sorry, but I have to fail this test for 2 minor things: Unrelated, but I spotted this when submitting an online text. Notice: Use of undefined constant FILE_INTERNAL - assumed 'FILE_INTERNAL' in /Users/fmc/code/php/repositories/im/moodle/mod/assignment/type/online/assignment.class.php on line 46 Notice: Use of undefined constant FILE_EXTERNAL - assumed 'FILE_EXTERNAL' in /Users/fmc/code/php/repositories/im/moodle/mod/assignment/type/online/assignment.class.php on line 47 After upgrading an 2.2 assignment to the new one, the setting "Comment inline" still appears as "No", though it is enabled as the teacher gets its feedback populated with the student's submission.
          Hide
          Damyon Wiese added a comment -

          Thanks Fred - nice catch. There is a fix here:

          git pull git://github.com/damyon/moodle.git MDL-34432-master-fix1

          The problem is not the upgrade - it's that the edit form does not reflect the value in the DB without this patch.

          Show
          Damyon Wiese added a comment - Thanks Fred - nice catch. There is a fix here: git pull git://github.com/damyon/moodle.git MDL-34432 -master-fix1 The problem is not the upgrade - it's that the edit form does not reflect the value in the DB without this patch.
          Hide
          Sam Hemelryk added a comment -

          Thanks guys, the fix has been pulled now.

          Show
          Sam Hemelryk added a comment - Thanks guys, the fix has been pulled now.
          Hide
          Frédéric Massart added a comment -

          Passing, and I have raised MDL-43454 for the constant issue.

          Show
          Frédéric Massart added a comment - Passing, and I have raised MDL-43454 for the constant issue.
          Hide
          Damyon Wiese added a comment -

          Twas the week before Christmas,
          And all though HQ
          Devs were scrambling to finish peer review.
          They sent all their issues,
          and rushed out the door -
          "To the beach!" someone heard them roar!

          This issue has been released upstream. Thanks!

          Show
          Damyon Wiese added a comment - Twas the week before Christmas, And all though HQ Devs were scrambling to finish peer review. They sent all their issues, and rushed out the door - "To the beach!" someone heard them roar! This issue has been released upstream. Thanks!
          Hide
          Mary Cooch added a comment -

          Removing qa_test_required as I have added MDLQA-6675 ready for copying over for 2.7 human QA testing.

          Show
          Mary Cooch added a comment - Removing qa_test_required as I have added MDLQA-6675 ready for copying over for 2.7 human QA testing.

            People

            • Votes:
              61 Vote for this issue
              Watchers:
              50 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Agile