Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34433

M.core_formchangechecker.set_form_changed fails with an error

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3.2
    • Component/s: Forms Library
    • Labels:
    • Testing Instructions:
      Hide
      1. Open any page with filemanager, for example Navigation->My profile->My private files; open Javascript console window
      2. Make changes ONLY to the filemanager area (add or rename file for example)
      3. Make sure there are no errors in Javascript console window; e.g.

        [Uncaught TypeError: Cannot read property 'target' of undefined]

      4. Click any link on the page
      5. Make sure the browser displays confirmation dialogue asking if you are sure you want to leave the page because the form has unsaved changes
      Show
      Open any page with filemanager, for example Navigation->My profile->My private files; open Javascript console window Make changes ONLY to the filemanager area (add or rename file for example) Make sure there are no errors in Javascript console window; e.g. [Uncaught TypeError: Cannot read property 'target' of undefined] Click any link on the page Make sure the browser displays confirmation dialogue asking if you are sure you want to leave the page because the form has unsaved changes
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-34433-master-1

      Description

      Regression from MDL-33874:

      lib/form/filemanager.js calls

      M.core_formchangechecker.set_form_changed()

      without arguments, i.e. e is undefined

      After your changes I get an error:

      Uncaught TypeError: Cannot read property 'target' of undefined
      M.core_formchangechecker.set_form_changed yui_combo.php:96
      Y.extend.filepicker_callback filemanager.js:190
      Y.extend.setup_select_file.getfile.on.request.callback filepicker.js:1181
      Y.extend.request.cfg.on.complete filepicker.js:605
      Y.Subscriber._notify event-custom-base.js:1154
      Y.Subscriber.notify event-custom-base.js:1183
      Y.CustomEvent._notify event-custom-base.js:879
      Y.CustomEvent._procSubs event-custom-base.js:984
      Y.CustomEvent.fire Simpleevent-custom-base.js:953
      Y.CustomEvent.fire event-custom-base.js:934
      ET.fire event-custom-base.js:1962
      IO._evt io-base.js:230
      IO.complete io-base.js:266
      IO._rS io-base.js:512

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    10/Sep/12