Moodle
  1. Moodle
  2. MDL-34441

finish dbtransfer tool implementation

    Details

    • Rank:
      42845

      Description

      1. fix and cleanup phpdocs
      2. we need to deal with log actions rewrite when switching db types
      3. CLI interface
      4. switch to maintenance mode when migrating from CLI, warn admins that user access must be somehow prevented when migrating via web U
      5. explain mysql case and accent insensitiveness madness at least in docs
      6. ignore all pdo db drivers instead of whitelisting
      7. add link visible link to experimental section for transfer (export is not ready yet sorry)
      8. automatic maintenance mode switching

      etc.

        Issue Links

          Activity

          Hide
          Dan Poltawski added a comment -
          Show
          Dan Poltawski added a comment - Can http://tracker.moodle.org/browse/MDL-15635 be closed?
          Hide
          Dan Poltawski added a comment -
          Show
          Dan Poltawski added a comment - Petr, it seems some subtasks have mysteriously disappeared from here.. http://webcache.googleusercontent.com/search?q=cache:XUvkrNGUpjgJ:tracker.moodle.org/browse/MDL-34442+&cd=10&hl=en&ct=clnk&gl=au
          Hide
          Petr Škoda added a comment - - edited

          Yep, I have deleted them because I would be a major PITA to create separate PULL requests for these - instead I have decided to use separate commits. The description lists resolved problems.

          Show
          Petr Škoda added a comment - - edited Yep, I have deleted them because I would be a major PITA to create separate PULL requests for these - instead I have decided to use separate commits. The description lists resolved problems.
          Hide
          Petr Škoda added a comment -

          I have cleaned up the GSOC meta issue, thanks for reminding me.

          Show
          Petr Škoda added a comment - I have cleaned up the GSOC meta issue, thanks for reminding me.
          Hide
          Dan Poltawski added a comment -

          I'm not sure we should be backporting this - need some +1s for that.

          Show
          Dan Poltawski added a comment - I'm not sure we should be backporting this - need some +1s for that.
          Hide
          Aparup Banerjee added a comment -

          just had a look, this seems backportable to 23 for me. aside from clean ups in lib/*, i think backporting an admin tool to stable should be OK since we're dealing with admins. Admins should always backup before doing anything, according to our documentation's many mentions. - anyway thats my +1 to backport from that pov.

          on the other hand i've no idea how well it works

          Show
          Aparup Banerjee added a comment - just had a look, this seems backportable to 23 for me. aside from clean ups in lib/*, i think backporting an admin tool to stable should be OK since we're dealing with admins. Admins should always backup before doing anything, according to our documentation's many mentions. - anyway thats my +1 to backport from that pov. on the other hand i've no idea how well it works
          Hide
          Dan Poltawski added a comment -

          OK, thats a +1. I've integrated this now.

          I did one commit on top to get the codechecker/phpdoc warnings to 0 (since we were so close to it anyway)

          Show
          Dan Poltawski added a comment - OK, thats a +1. I've integrated this now. I did one commit on top to get the codechecker/phpdoc warnings to 0 (since we were so close to it anyway)
          Hide
          Dan Poltawski added a comment -

          Tested migration from postgres to mysql, worked on web and everything looked in order. Attempted the same on CLI and looked good.

          I noticed that the CLI script attempted to migrate even if no moodle is installed. In the interests of expediency I pushed a quick fix to prevent that.

          Show
          Dan Poltawski added a comment - Tested migration from postgres to mysql, worked on web and everything looked in order. Attempted the same on CLI and looked good. I noticed that the CLI script attempted to migrate even if no moodle is installed. In the interests of expediency I pushed a quick fix to prevent that.
          Hide
          fred frazelle added a comment -

          i'm still having difficulties finishing the transfer.

          http://tracker.moodle.org/browse/MDL-34381?focusedCommentId=169227#comment-169227

          Should i just go ahead and upgrade using SQL and then try again?

          Show
          fred frazelle added a comment - i'm still having difficulties finishing the transfer. http://tracker.moodle.org/browse/MDL-34381?focusedCommentId=169227#comment-169227 Should i just go ahead and upgrade using SQL and then try again?
          Hide
          Petr Škoda added a comment - - edited

          The dbtransfer is not a magic tool that fixes existing problems automatically, it can fix only some problems such as missing indexes, some colum size issues, etc. You should enable developer debug mode to get detailed error messages (I am going to force the debug on in the next patch) and then manually fix the problems.

          Show
          Petr Škoda added a comment - - edited The dbtransfer is not a magic tool that fixes existing problems automatically, it can fix only some problems such as missing indexes, some colum size issues, etc. You should enable developer debug mode to get detailed error messages (I am going to force the debug on in the next patch) and then manually fix the problems.
          Hide
          Aparup Banerjee added a comment -

          yay, it works!

          This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.

          Thank you all for taking the time to get us here.

          cheers!

          Show
          Aparup Banerjee added a comment - yay, it works! This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week. Thank you all for taking the time to get us here. cheers!
          Hide
          Aparup Banerjee added a comment -

          ah, should this have had 'tool_' prefixed in admin/tool/dbtransfer/locallib.php ? i think someone was dreaming of namespaces :-p

          Show
          Aparup Banerjee added a comment - ah, should this have had 'tool_' prefixed in admin/tool/dbtransfer/locallib.php ? i think someone was dreaming of namespaces :-p
          Show
          Dan Poltawski added a comment - Apu, that was fixed: http://git.moodle.org/gw?p=moodle.git;a=blobdiff;f=admin/tool/dbtransfer/locallib.php;h=140691d75fc8102f7f3a343c24ca54ea127c72e4;hp=f36ceef614a7375fec91e791b1b73ee75d97cf82;hb=5a773597de00ae3c0db3c8e59228a60011ce8cac;hpb=e9324a2274bf02aa4281e5d96e5eeb596ebbf86e
          Hide
          Aparup Banerjee added a comment -

          (doh) didn't realise i was browsing through older code .

          Show
          Aparup Banerjee added a comment - (doh) didn't realise i was browsing through older code .
          Hide
          Helen Foster added a comment -

          I've just created a page in the 2.3 docs for this new feature - http://docs.moodle.org/23/en/Database_transfer Help with adding info about it would be much appreciated!

          Show
          Helen Foster added a comment - I've just created a page in the 2.3 docs for this new feature - http://docs.moodle.org/23/en/Database_transfer Help with adding info about it would be much appreciated!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: