Moodle
  1. Moodle
  2. MDL-34449

fix page layout options handling

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: 2.3
        • Fix Version/s: 2.3.2, 2.4
        • Component/s: General
        • Labels:
        • Rank:
          42852

          Description

          At present the theme layout options is fetched way too early which prevents layout switching before the $PAGE->header(), this is driving me absolutely crazy especially on admin pages!

          Solution is trivial - fetch the layout options later when they are necessary...

            Issue Links

            blocks

            Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-34441 finish dbtransfer tool implementation

            • Major - Major loss of function, incorrect output
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Aparup Banerjee added a comment -

              thanks Petr. Thats in master and 23, thanks.

              Tester: i don't think its likely at all but apart from the simple test described, perhaps you may want to note any performance changes?

              Show
              Aparup Banerjee added a comment - thanks Petr. Thats in master and 23, thanks. Tester: i don't think its likely at all but apart from the simple test described, perhaps you may want to note any performance changes?
              Hide
              Permalink
              Frédéric Massart added a comment -

              Test successful on master and 2.3. Thanks!

              Show
              Frédéric Massart added a comment - Test successful on master and 2.3. Thanks!
              Hide
              Permalink
              Aparup Banerjee added a comment -

              yay, it works!

              This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.

              Thank you all for taking the time to get us here.

              cheers!

              Show
              Aparup Banerjee added a comment - yay, it works! This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week. Thank you all for taking the time to get us here. cheers!

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: