Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34449

fix page layout options handling

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3.2, 2.4
    • Component/s: General
    • Labels:

      Description

      At present the theme layout options is fetched way too early which prevents layout switching before the $PAGE->header(), this is driving me absolutely crazy especially on admin pages!

      Solution is trivial - fetch the layout options later when they are necessary...

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              nebgor Aparup Banerjee added a comment -

              thanks Petr. Thats in master and 23, thanks.

              Tester: i don't think its likely at all but apart from the simple test described, perhaps you may want to note any performance changes?

              Show
              nebgor Aparup Banerjee added a comment - thanks Petr. Thats in master and 23, thanks. Tester: i don't think its likely at all but apart from the simple test described, perhaps you may want to note any performance changes?
              Hide
              fred Frédéric Massart added a comment -

              Test successful on master and 2.3. Thanks!

              Show
              fred Frédéric Massart added a comment - Test successful on master and 2.3. Thanks!
              Hide
              nebgor Aparup Banerjee added a comment -

              yay, it works!

              This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.

              Thank you all for taking the time to get us here.

              cheers!

              Show
              nebgor Aparup Banerjee added a comment - yay, it works! This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week. Thank you all for taking the time to get us here. cheers!

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    10/Sep/12