Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide

      Test 1

      1. Browse through the admin
      • Follow any links
      • Edit and save forms
      • Make sure no exceptions are raised on any page

      (If an exception is raised, make sure it is related to get_context_instance() before failing the test)

      Golden Test (optional)

      1. Make sure Moodle works
      Show
      Test 1 Browse through the admin Follow any links Edit and save forms Make sure no exceptions are raised on any page (If an exception is raised, make sure it is related to get_context_instance() before failing the test) Golden Test (optional) Make sure Moodle works
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-34455-master-integration

      Description

      Replace get_context_instance with context_XXXX::instance() in set location (group 1)
      Locations

      • Admin

        Gliffy Diagrams

          Issue Links

            Activity

            Adrian Greeve created issue -
            Adrian Greeve made changes -
            Field Original Value New Value
            Fix Version/s STABLE Sprint 22 [ 12156 ]
            Ankit Agarwal made changes -
            Link This issue blocks MDL-34471 [ MDL-34471 ]
            Frédéric Massart made changes -
            Assignee Petr Škoda (skodak) [ skodak ] Frédéric Massart [ fred ]
            Frédéric Massart made changes -
            Status Open [ 1 ] Development in progress [ 3 ]
            Frédéric Massart made changes -
            Status Development in progress [ 3 ] Waiting for peer review [ 10012 ]
            Pull Master Diff URL https://github.com/FMCorz/moodle/compare/master...MDL-34455-master-integration
            Pull Master Branch MDL-34455-master-integration
            Pull from Repository git://github.com/FMCorz/moodle.git
            Dan Poltawski made changes -
            Status Waiting for peer review [ 10012 ] Waiting for integration review [ 10010 ]
            Dan Poltawski made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Integrator poltawski
            Currently in integration Yes [ 10041 ]
            Hide
            Dan Poltawski added a comment -

            Thanks Fred, thats integrated now. Please could you add some basic testing instructions.

            Show
            Dan Poltawski added a comment - Thanks Fred, thats integrated now. Please could you add some basic testing instructions.
            Dan Poltawski made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            Fix Version/s 2.4 [ 12255 ]
            Dan Poltawski made changes -
            Labels triaged
            Frédéric Massart made changes -
            Testing Instructions *Test 1*

            # Browse through the admin
            - Follow any links
            - Edit and save forms
            - *Make sure* no exceptions are raised on any page

            (If an exception is raised, *make sure* it is related to get_context_instance() before failing the test)

            *Golden Test* (optional)

            # *Make sure* Moodle works
            Tim Barker made changes -
            Tester davmon
            David Monllaó made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Hide
            David Monllaó added a comment -

            Tested several settings pages, upload user tool, user profile fields, bulk user actions, web services settings... without any problem. I've also tested as few CLI scripts as Fred proposed. It passes.

            Show
            David Monllaó added a comment - Tested several settings pages, upload user tool, user profile fields, bulk user actions, web services settings... without any problem. I've also tested as few CLI scripts as Fred proposed. It passes.
            David Monllaó made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            Hide
            Aparup Banerjee added a comment -

            yay, it works!

            This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.

            Thank you all for taking the time to get us here.

            cheers!

            Show
            Aparup Banerjee added a comment - yay, it works! This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week. Thank you all for taking the time to get us here. cheers!
            Aparup Banerjee made changes -
            Status Tested [ 10006 ] Closed [ 6 ]
            Resolution Fixed [ 1 ]
            Currently in integration Yes [ 10041 ]
            Integration date 26/Jul/12
            Eloy Lafuente (stronk7) made changes -
            Fix Version/s STABLE Sprint 22 [ 12156 ]

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: