Moodle
  1. Moodle
  2. MDL-33061 META : Remove deprecated api function get_context_instance() and replace calls with context_XXX::instance()
  3. MDL-34461

Replace get_context_instance with context_XXXX::instance() in set location (group 5)

        Details

        • Type: Sub-task Sub-task
        • Status: Closed
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: 2.4
        • Fix Version/s: 2.4
        • Component/s: Libraries
        • Labels:
        • Testing Instructions:
          Hide

          Test 1

          1. Browse through the enrolment options
          2. Create a mess, do whatever you want
          • Make sure no exceptions are raised on any page

          (If an exception is raised, make sure it is related to get_context_instance() before failing the test)

          Easter bunny Test (optional)

          1. Find the White-striped easter egg
          2. Make sure Moodle works
          Show
          Test 1 Browse through the enrolment options Create a mess, do whatever you want Make sure no exceptions are raised on any page (If an exception is raised, make sure it is related to get_context_instance() before failing the test) Easter bunny Test (optional) Find the White-striped easter egg Make sure Moodle works
        • Affected Branches:
          MOODLE_24_STABLE
        • Fixed Branches:
          MOODLE_24_STABLE
        • Pull from Repository:
        • Pull Master Branch:
          MDL-34461-master-integration
        • Pull Master Diff URL:
        • Rank:
          42876

          Description

          Replace get_context_instance with context_XXXX::instance() in set location (group 5)
          Location

          • enrol/

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Dan Poltawski added a comment -

            Thanks Fred, this has been integrated now.

            Show
            Dan Poltawski added a comment - Thanks Fred, this has been integrated now.
            Hide
            Permalink
            David Monllaó added a comment -

            Tested playing with the enrolment plugins settings pages and enrolling users using the methods guest access, self enrolment, cohort IMS enterprise file and course meta link. No errors nor problems, it passes.

            Show
            David Monllaó added a comment - Tested playing with the enrolment plugins settings pages and enrolling users using the methods guest access, self enrolment, cohort IMS enterprise file and course meta link. No errors nor problems, it passes.
            Hide
            Permalink
            Aparup Banerjee added a comment -

            yay, it works!

            This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.

            Thank you all for taking the time to get us here.

            cheers!

            Show
            Aparup Banerjee added a comment - yay, it works! This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week. Thank you all for taking the time to get us here. cheers!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: