Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Libraries
    • Labels:

      Description

      Replace get_context_instance with context_XXXX::instance() in set location (group 8)
      Location

      • lib/

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            David Monllaó added a comment -

            Hi Adrian,

            All perfect for me, the only thing I'm not sure about is in lib/gradelib.php line ~761; the instance() call has an IGNORE_MISSING but the grade_get_letters($context) argument is optional and it returns a hardcoded list of values in case $context is null, so the return ''; of lib/gradelib.php line ~763 would not be executed and grade_format_gradevalue_letter would continue it's execution without a valid course context; I'm not sure if this is the expected behaviour

            Show
            David Monllaó added a comment - Hi Adrian, All perfect for me, the only thing I'm not sure about is in lib/gradelib.php line ~761; the instance() call has an IGNORE_MISSING but the grade_get_letters($context) argument is optional and it returns a hardcoded list of values in case $context is null, so the return ''; of lib/gradelib.php line ~763 would not be executed and grade_format_gradevalue_letter would continue it's execution without a valid course context; I'm not sure if this is the expected behaviour
            Hide
            David Monllaó added a comment -

            Sorry Adrian, I misunderstood how it works, forget my comment, all is ok

            Show
            David Monllaó added a comment - Sorry Adrian, I misunderstood how it works, forget my comment, all is ok
            Hide
            Dan Poltawski added a comment -

            Thanks Adrian, i've integrated this now.

            Show
            Dan Poltawski added a comment - Thanks Adrian, i've integrated this now.
            Hide
            Rossiani Wijaya added a comment -

            Looks good.

            Test passed.

            Show
            Rossiani Wijaya added a comment - Looks good. Test passed.
            Hide
            Dan Poltawski added a comment -

            asko, Дзякуй, ধন্যবাদ, Благодаря, Gràcies, 感谢, 謝謝, Hvala, Díky, Tak, Bedankt, Tänan, متشکریم, Salamat, Kiitokset, Merci, Grazas, Danke, Ευχαριστώ, આભાર, תודה, धन्यवाद, Köszönjük, Takk fyrir, Terima Kasih, Grazie, ありがとうございます, Рахмет, សូមអរគុណ, 감사합니다, gratiās, Pateicamies, Ačiū, Благодарам, Tēnā koa, Kia Ora Rawa Atu, आभारी आहोत, Талархал, Takk, Dziękuję, Obrigado, Mulţumesc, Engraziel, Спасибо, Fa'afetai, Хвала, Hvala, ස්තූතියි, Vďaka, Hvala, Mahadsanid, Thanks, Gracias, Tack, Salamat, நன்றி, నెనరులు, ขอบคุณค่ะ!

            Your work has made it into this weeks Moodle release! There are no gold medals available this week - but millions around the world will benefit. Thank you!

            Show
            Dan Poltawski added a comment - asko, Дзякуй, ধন্যবাদ, Благодаря, Gràcies, 感谢, 謝謝, Hvala, Díky, Tak, Bedankt, Tänan, متشکریم, Salamat, Kiitokset, Merci, Grazas, Danke, Ευχαριστώ, આભાર, תודה, धन्यवाद, Köszönjük, Takk fyrir, Terima Kasih, Grazie, ありがとうございます, Рахмет, សូមអរគុណ, 감사합니다, gratiās, Pateicamies, Ačiū, Благодарам, Tēnā koa, Kia Ora Rawa Atu, आभारी आहोत, Талархал, Takk, Dziękuję, Obrigado, Mulţumesc, Engraziel, Спасибо, Fa'afetai, Хвала, Hvala, ස්තූතියි, Vďaka, Hvala, Mahadsanid, Thanks, Gracias, Tack, Salamat, நன்றி, నెనరులు, ขอบคุณค่ะ! Your work has made it into this weeks Moodle release! There are no gold medals available this week - but millions around the world will benefit. Thank you!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: