Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33061 META : Remove deprecated api function get_context_instance() and replace calls with context_XXX::instance()
  3. MDL-34466

Replace get_context_instance with context_XXXX::instance() in set location (group 12)

          Details

          • Type: Sub-task
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 2.4
          • Fix Version/s: 2.4
          • Component/s: Libraries
          • Labels:
          • Testing Instructions:
            Hide

            This issue affects mod/assignment, mod/chat, mod/choice and mod/folder (there are no modifications in mod/assign) general testing checking that no exceptions are thrown

            1. mod/assignment
              1. Create assignments (only upload, uploadsingle and online have been modified)
              2. Grade them
            2. mod/chat
              1. Create chat activities
              2. Try with different GUIs (change the chat_method in Site administration -> Plugins -> Activity modules -> Chat)
            3. mod/choice
              1. Create a choice activity
              2. View it
            4. mod/folder
              1. Create a folder
              2. View it
            Show
            This issue affects mod/assignment, mod/chat, mod/choice and mod/folder (there are no modifications in mod/assign) general testing checking that no exceptions are thrown mod/assignment Create assignments (only upload, uploadsingle and online have been modified) Grade them mod/chat Create chat activities Try with different GUIs (change the chat_method in Site administration -> Plugins -> Activity modules -> Chat) mod/choice Create a choice activity View it mod/folder Create a folder View it
          • Affected Branches:
            MOODLE_24_STABLE
          • Fixed Branches:
            MOODLE_24_STABLE
          • Pull from Repository:
          • Pull Master Branch:
            MDL-34466_master
          • Pull Master Diff URL:

            Description

            Replace get_context_instance with context_XXXX::instance() in set location (group 12)
            Locations

            • Mod/assign
            • Mod/assignment
            • mod/chat
            • mod/choice
            • mod/folder

              Gliffy Diagrams

                Attachments

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  fred Frédéric Massart added a comment -

                  Thanks David, patch look good. Submit for integration when you're ready.

                  Show
                  fred Frédéric Massart added a comment - Thanks David, patch look good. Submit for integration when you're ready.
                  Hide
                  Permalink
                  dmonllao David Monllaó added a comment -

                  Thanks for peer reviewing and for the comments Fred; submitting for integration review

                  Show
                  dmonllao David Monllaó added a comment - Thanks for peer reviewing and for the comments Fred; submitting for integration review
                  Hide
                  Permalink
                  dmonllao David Monllaó added a comment -

                  Adding testing instructions

                  Show
                  dmonllao David Monllaó added a comment - Adding testing instructions
                  Hide
                  Permalink
                  poltawski Dan Poltawski added a comment -

                  Integrated, thanks David.

                  Show
                  poltawski Dan Poltawski added a comment - Integrated, thanks David.
                  Hide
                  Permalink
                  rwijaya Rossiani Wijaya added a comment -

                  This looks good.

                  Test passed.

                  Show
                  rwijaya Rossiani Wijaya added a comment - This looks good. Test passed.
                  Hide
                  Permalink
                  poltawski Dan Poltawski added a comment -

                  asko, Дзякуй, ধন্যবাদ, Благодаря, Gràcies, 感谢, 謝謝, Hvala, Díky, Tak, Bedankt, Tänan, متشکریم, Salamat, Kiitokset, Merci, Grazas, Danke, Ευχαριστώ, આભાર, תודה, धन्यवाद, Köszönjük, Takk fyrir, Terima Kasih, Grazie, ありがとうございます, Рахмет, សូមអរគុណ, 감사합니다, gratiās, Pateicamies, Ačiū, Благодарам, Tēnā koa, Kia Ora Rawa Atu, आभारी आहोत, Талархал, Takk, Dziękuję, Obrigado, Mulţumesc, Engraziel, Спасибо, Fa'afetai, Хвала, Hvala, ස්තූතියි, Vďaka, Hvala, Mahadsanid, Thanks, Gracias, Tack, Salamat, நன்றி, నెనరులు, ขอบคุณค่ะ!

                  Your work has made it into this weeks Moodle release! There are no gold medals available this week - but millions around the world will benefit. Thank you!

                  Show
                  poltawski Dan Poltawski added a comment - asko, Дзякуй, ধন্যবাদ, Благодаря, Gràcies, 感谢, 謝謝, Hvala, Díky, Tak, Bedankt, Tänan, متشکریم, Salamat, Kiitokset, Merci, Grazas, Danke, Ευχαριστώ, આભાર, תודה, धन्यवाद, Köszönjük, Takk fyrir, Terima Kasih, Grazie, ありがとうございます, Рахмет, សូមអរគុណ, 감사합니다, gratiās, Pateicamies, Ačiū, Благодарам, Tēnā koa, Kia Ora Rawa Atu, आभारी आहोत, Талархал, Takk, Dziękuję, Obrigado, Mulţumesc, Engraziel, Спасибо, Fa'afetai, Хвала, Hvala, ස්තූතියි, Vďaka, Hvala, Mahadsanid, Thanks, Gracias, Tack, Salamat, நன்றி, నెనరులు, ขอบคุณค่ะ! Your work has made it into this weeks Moodle release! There are no gold medals available this week - but millions around the world will benefit. Thank you!

                    People

                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      0 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:
                        Fix Release Date:
                        3/Dec/12