Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide

      This issue affects a lot of pages in the affected modules with out any functionality change. So just look for regressions.

      TEST1-glossary

      • Try creating/editing/deleting/updating a glossary activity
      • Try creating/editing/updating/copying/deleting a glossary entry
      • Try browsing through other glossary options

      TEST2-imscp

      • Try all possible combination of settings for the module

      TEST3-label

      • Try creating/editing/deleting/updating a label resource
      • Try browsing through other label options

      TEST4-Lesson

      • Try creating/editing/deleting/updating a lesson
      • Attempt the lesson as a student
      • Try browsing through other lesson options

      TEST5-LTI

      • Test various settings/configuration of an LTI module

      TEST6-PAGE

      • Try creating/editing/deleting/updating a page resource
      • Try browsing through other page options

      TEST7-Olympics (optional)

      • Take part in 2012 olympics and bring gold back!
      • Test rest of activites/resources and make sure nothing is broken.
      Show
      This issue affects a lot of pages in the affected modules with out any functionality change. So just look for regressions. TEST1-glossary Try creating/editing/deleting/updating a glossary activity Try creating/editing/updating/copying/deleting a glossary entry Try browsing through other glossary options TEST2-imscp Try all possible combination of settings for the module TEST3-label Try creating/editing/deleting/updating a label resource Try browsing through other label options TEST4-Lesson Try creating/editing/deleting/updating a lesson Attempt the lesson as a student Try browsing through other lesson options TEST5-LTI Test various settings/configuration of an LTI module TEST6-PAGE Try creating/editing/deleting/updating a page resource Try browsing through other page options TEST7-Olympics (optional) Take part in 2012 olympics and bring gold back! Test rest of activites/resources and make sure nothing is broken.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-34467-master
    • Rank:
      42882

      Description

      Replace get_context_instance with context_XXXX::instance() in set location (group 13)
      Locations

      • mod/ glossary
      • mod/imscp
      • mod/label
      • mod/lesson
      • mod/lti
      • mod/page

        Issue Links

          Activity

          Hide
          Frédéric Massart added a comment -

          Looks good to me Ankit. Pushing for integration. Thanks!

          Show
          Frédéric Massart added a comment - Looks good to me Ankit. Pushing for integration. Thanks!
          Hide
          Ankit Agarwal added a comment -

          Thanks for the review Fred!

          Show
          Ankit Agarwal added a comment - Thanks for the review Fred!
          Hide
          Dan Poltawski added a comment -

          Integrated, thanks Ankit!

          Show
          Dan Poltawski added a comment - Integrated, thanks Ankit!
          Hide
          Rossiani Wijaya added a comment -

          With the exception of getting the Olympic gold medal, this issue looks good.

          Test passed.

          Show
          Rossiani Wijaya added a comment - With the exception of getting the Olympic gold medal, this issue looks good. Test passed.
          Hide
          Dan Poltawski added a comment -

          asko, Дзякуй, ধন্যবাদ, Благодаря, Gràcies, 感谢, 謝謝, Hvala, Díky, Tak, Bedankt, Tänan, متشکریم, Salamat, Kiitokset, Merci, Grazas, Danke, Ευχαριστώ, આભાર, תודה, धन्यवाद, Köszönjük, Takk fyrir, Terima Kasih, Grazie, ありがとうございます, Рахмет, សូមអរគុណ, 감사합니다, gratiās, Pateicamies, Ačiū, Благодарам, Tēnā koa, Kia Ora Rawa Atu, आभारी आहोत, Талархал, Takk, Dziękuję, Obrigado, Mulţumesc, Engraziel, Спасибо, Fa'afetai, Хвала, Hvala, ස්තූතියි, Vďaka, Hvala, Mahadsanid, Thanks, Gracias, Tack, Salamat, நன்றி, నెనరులు, ขอบคุณค่ะ!

          Your work has made it into this weeks Moodle release! There are no gold medals available this week - but millions around the world will benefit. Thank you!

          Show
          Dan Poltawski added a comment - asko, Дзякуй, ধন্যবাদ, Благодаря, Gràcies, 感谢, 謝謝, Hvala, Díky, Tak, Bedankt, Tänan, متشکریم, Salamat, Kiitokset, Merci, Grazas, Danke, Ευχαριστώ, આભાર, תודה, धन्यवाद, Köszönjük, Takk fyrir, Terima Kasih, Grazie, ありがとうございます, Рахмет, សូមអរគុណ, 감사합니다, gratiās, Pateicamies, Ačiū, Благодарам, Tēnā koa, Kia Ora Rawa Atu, आभारी आहोत, Талархал, Takk, Dziękuję, Obrigado, Mulţumesc, Engraziel, Спасибо, Fa'afetai, Хвала, Hvala, ස්තූතියි, Vďaka, Hvala, Mahadsanid, Thanks, Gracias, Tack, Salamat, நன்றி, నెనరులు, ขอบคุณค่ะ! Your work has made it into this weeks Moodle release! There are no gold medals available this week - but millions around the world will benefit. Thank you!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: