Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide

      This patch literately affects every single page of the related mods without any functionality change. So basically we need to look for regressions.
      Test1

      • Test all possible configurations/options/settings of survey
        Test2
      • Test all possible configurations/options/settings of Scorm
      • Upload scorm
      • Submit attempts as student
      • Delete /edit/update attempts as teacher
      • view reports as teacher

      Test3

      • Test all possible configurations/options/settings of quiz
      • Try creating quiz with various question types
      • attempting quiz as student
      • editing/deleting quiz attempts
      • checkout quiz reports as teacher

      White Rabbit test (optional)

      • Follow the white rabbit, till you reach the Matrix
      • Once there make sure this patch doesn't break Moodle. So test everything.
      Show
      This patch literately affects every single page of the related mods without any functionality change. So basically we need to look for regressions. Test1 Test all possible configurations/options/settings of survey Test2 Test all possible configurations/options/settings of Scorm Upload scorm Submit attempts as student Delete /edit/update attempts as teacher view reports as teacher Test3 Test all possible configurations/options/settings of quiz Try creating quiz with various question types attempting quiz as student editing/deleting quiz attempts checkout quiz reports as teacher White Rabbit test (optional) Follow the white rabbit, till you reach the Matrix Once there make sure this patch doesn't break Moodle. So test everything.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-34468-master

      Description

      Replace get_context_instance with context_XXXX::instance() in set location (group 14)
      Locations

      • mod/survey
      • mod/quiz
      • mod/resources
      • mod/scorm

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            ankit_frenz Ankit Agarwal added a comment -

            Adding Dan and Tim as watchers as they are the component owners of the code effected by this issue.

            Show
            ankit_frenz Ankit Agarwal added a comment - Adding Dan and Tim as watchers as they are the component owners of the code effected by this issue.
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            I donot see any place where the call should be using IGNORE_MISSING strictness.
            Requesting a review.
            Thanks

            Show
            ankit_frenz Ankit Agarwal added a comment - I donot see any place where the call should be using IGNORE_MISSING strictness. Requesting a review. Thanks
            Hide
            poltawski Dan Poltawski added a comment -

            Pulling this in (like the rest of the issues), trying to get as much as this branch breaking changes into one week.

            Show
            poltawski Dan Poltawski added a comment - Pulling this in (like the rest of the issues), trying to get as much as this branch breaking changes into one week.
            Hide
            poltawski Dan Poltawski added a comment -

            Integrated, thanks Ankit

            Show
            poltawski Dan Poltawski added a comment - Integrated, thanks Ankit
            Hide
            rwijaya Rossiani Wijaya added a comment -

            Noticed an error on quiz attempts result, which is not related to this issue. I create new issue to fix the error (MDL-34532).

            This looks good Ankit.

            Test passed.

            Show
            rwijaya Rossiani Wijaya added a comment - Noticed an error on quiz attempts result, which is not related to this issue. I create new issue to fix the error ( MDL-34532 ). This looks good Ankit. Test passed.
            Hide
            nebgor Aparup Banerjee added a comment -

            yay, it works!

            This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.

            Thank you all for taking the time to get us here.

            cheers!

            Show
            nebgor Aparup Banerjee added a comment - yay, it works! This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week. Thank you all for taking the time to get us here. cheers!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Dec/12