Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Libraries
    • Labels:
      None
    • Testing Instructions:
      Hide
      1. It is very difficult to test this in the UI, since literately every single functionality in the related modules is affected by these changes. so I suggest just code review + greping for remaining instances of get_context_instance() in mod/url , mod/wiki and mod/workshop should be enough.
      Show
      It is very difficult to test this in the UI, since literately every single functionality in the related modules is affected by these changes. so I suggest just code review + greping for remaining instances of get_context_instance() in mod/url , mod/wiki and mod/workshop should be enough.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-34470-master

      Description

      Replace get_context_instance with context_XXXX::instance() in set location (group 16)
      Locations

      • mod/url
      • mod/wiki
      • mod/workshop

        Gliffy Diagrams

          Activity

          Hide
          Ankit Agarwal added a comment -

          Note:- The diff is on top of latest integration not stable, to reduce conflicts.
          Thanks

          Show
          Ankit Agarwal added a comment - Note:- The diff is on top of latest integration not stable, to reduce conflicts. Thanks
          Hide
          Adrian Greeve added a comment -

          Hello Ankit,

          The changes look fine and I didn't find any instances that hadn't been changed over.

          Thanks for your help.

          Show
          Adrian Greeve added a comment - Hello Ankit, The changes look fine and I didn't find any instances that hadn't been changed over. Thanks for your help.
          Hide
          Ankit Agarwal added a comment -

          Thanks Adrian for the review,
          Putting up for integration.
          Thanks

          Show
          Ankit Agarwal added a comment - Thanks Adrian for the review, Putting up for integration. Thanks
          Hide
          Dan Poltawski added a comment -

          Thanks Ankit, i've integrated this now.

          Show
          Dan Poltawski added a comment - Thanks Ankit, i've integrated this now.
          Hide
          Dan Poltawski added a comment -

          Tested some basics of workshop, url and wiki and looked good.

          Wasn't an exhaustive test, but hopefully any problems will come out in the dev cycle.

          Show
          Dan Poltawski added a comment - Tested some basics of workshop, url and wiki and looked good. Wasn't an exhaustive test, but hopefully any problems will come out in the dev cycle.
          Hide
          Aparup Banerjee added a comment -

          yay, it works!

          This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.

          Thank you all for taking the time to get us here.

          cheers!

          Show
          Aparup Banerjee added a comment - yay, it works! This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week. Thank you all for taking the time to get us here. cheers!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: