Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34434 META: Collect together deprecated code changes for Moodle 2.6
  3. MDL-34472

Add deprecate warning to get_context_instance() function

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.6
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide
      1. make sure get_context_instance() is not used in core except in one unit test.
      2. Try adding something like print_object(get_context_instance(CONTEXT_COURSE, $courseid));
      3. Make sure it works with warning in developer mode.
      4. make sure all unit tests pass as before
      5. Visit user system profile page and course profile page, make sure there are no debug warnings/errors
      6. Download and upload gradesheet for an assignment and make sure no errors are shown (Home ► Courses ► Miscellaneous ► test ► General ► Assignment ► Grading)
      Show
      make sure get_context_instance() is not used in core except in one unit test. Try adding something like print_object(get_context_instance(CONTEXT_COURSE, $courseid)); Make sure it works with warning in developer mode. make sure all unit tests pass as before Visit user system profile page and course profile page, make sure there are no debug warnings/errors Download and upload gradesheet for an assignment and make sure no errors are shown (Home ► Courses ► Miscellaneous ► test ► General ► Assignment ► Grading)
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-34472-master
    • Pull Master Diff URL:
    • Story Points:
      3
    • Sprint:
      BACKEND Sprint 2

      Description

      Add deprecate warning to get_context_instance() function

        Attachments

          Issue Links

          blocks

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-34548 Remove get_context_instance() from core

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-40470 url_select triggers on click not on change.

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed
          has been marked as being related by

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-55194 Final deprecation of get_context_instance()

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is blocked by

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-34471 Replace get_context_instance with context_XXXX::instance() in set location (Cleanup issue)

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-33061 META : Remove deprecated api function get_context_instance() and replace calls with context_XXX::instance()

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              ankit_frenz Ankit Agarwal
              Reporter:
              ankit_frenz Ankit Agarwal
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Mark Nelson
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/13