Loading...

XML

Word

Printable

Affected Branches:
MOODLE_24_STABLE
Fixed Branches:
MOODLE_26_STABLE
Pull from Repository:
git://github.com/ankitagarwal/moodle.git
Pull Main Branch:
~~MDL-34472~~-master
Pull Main Diff URL:
https://github.com/ankitagarwal/moodle/compare/moodle:master...MDL-34472-master
Testing Instructions:
Hide

make sure get_context_instance() is not used in core except in one unit test.

Try adding something like print_object(get_context_instance(CONTEXT_COURSE, $courseid));

Make sure it works with warning in developer mode.

make sure all unit tests pass as before

Visit user system profile page and course profile page, make sure there are no debug warnings/errors

Download and upload gradesheet for an assignment and make sure no errors are shown (Home ► Courses ► Miscellaneous ► test ► General ► Assignment ► Grading)
Show
make sure get_context_instance() is not used in core except in one unit test. Try adding something like print_object(get_context_instance(CONTEXT_COURSE, $courseid)); Make sure it works with warning in developer mode. make sure all unit tests pass as before Visit user system profile page and course profile page, make sure there are no debug warnings/errors Download and upload gradesheet for an assignment and make sure no errors are shown (Home ► Courses ► Miscellaneous ► test ► General ► Assignment ► Grading)

Add deprecate warning to get_context_instance() function

blocks

MDL-34548 Remove get_context_instance() from core

Discovered while testing

MDL-40470 url_select triggers on click not on change.

has been marked as being related by

MDL-55194 Final deprecation of get_context_instance()

is blocked by

MDL-34471 Replace get_context_instance with context_XXXX::instance() in set location (Cleanup issue)

MDL-33061 META : Remove deprecated api function get_context_instance() and replace calls with context_XXX::instance()

Participants:: Ankit Agarwal, Damyon Wiese, Dan Poltawski, Eloy Lafuente (stronk7), Mark Nelson, Martin Dougiamas, Michael de Raadt, Rajesh Taneja