Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34476

Completion block's "full course report" is unavailable to Teachers

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Enable course completion on a course
      2. Add the course completion block to the course page
      3. Login as a teacher and ensure you can see "View Course report" in addition to the normal course completion details
      4. Login as an admin who is not enrolled in the course and ensure you are told you aren't enrolled in the course, but can see the "View Course report"
      5. Login as an student and ensure you can see the normal course completion details
      Show
      Enable course completion on a course Add the course completion block to the course page Login as a teacher and ensure you can see "View Course report" in addition to the normal course completion details Login as an admin who is not enrolled in the course and ensure you are told you aren't enrolled in the course, but can see the "View Course report" Login as an student and ensure you can see the normal course completion details
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-34476-master

      Description

      Only unenrolled users (Managers and Administrators) can see full course completion report
      Teachers, that need it most, are unable to see the report since they are enrolled into the course.
      Surely this is not the intended behavior (Am i right?)

      blocks/completionstatus/block_completionstatus.php

      // Check this user is enroled
      if (!$info->is_tracked_user($USER->id)) {

      lib/completionlib.php

          public function is_tracked_user($userid) {
              return is_enrolled(context_course::instance($this->course->id), $userid, '', true);
          }

      Looking into the above code, It seems there should be a distinction between students and all the rest (Teachers and Administration stuff) regarding "Who should be able to see the complete course completion report"

        Attachments

          Activity

            People

            Assignee:
            phalacee Jason Fowler
            Reporter:
            nadavkav Nadav Kavalerchik
            Peer reviewer:
            Frédéric Massart
            Integrator:
            Sam Hemelryk
            Tester:
            David Monllaó
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            7 Vote for this issue
            Watchers:
            7 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              12/Nov/12